code review 53410043: net: skip TestDualStackTCPListener in short mode

net: skip TestDualStackTCPListener in short mode

Update issue 5001

This test is flakey on linux servers and fails otherwise good builds. Mikio has some proposals to fix the test, but they require additional plumbing.

In the meantime, disable this test in -short mode so it will run during the full net test suite, but not during builder ci.

[dave_cheney.net, 2014-01-16 21:58:29]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[iant, 2014-01-16 22:12:47]

LGTM

Thank you.

Want to fix the misspelling of "different" in the function comment while you're
there?

[dave_cheney.net, 2014-01-16 22:44:18]

On 2014/01/16 22:12:47, iant wrote:
> LGTM
> 
> Thank you.
> 
> Want to fix the misspelling of "different" in the function comment while
you're
> there?

Done, submitting.

[dave_cheney.net, 2014-01-16 22:49:58]

*** Submitted as https://code.google.com/p/go/source/detail?r=97cc79d65fae ***

net: skip TestDualStackTCPListener in short mode

Update issue 5001

This test is flakey on linux servers and fails otherwise good builds. Mikio has
some proposals to fix the test, but they require additional plumbing.

In the meantime, disable this test in -short mode so it will run during the full
net test suite, but not during builder ci.

R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/53410043

[mikio, 2014-01-16 23:21:12]

Do you want to add solaris port w/o the test harness?

[aram, 2014-01-18 14:00:53]

On 2014/01/16 23:21:12, mikio wrote:
> Do you want to add solaris port w/o the test harness?

What do you mean?

[mikio, 2014-01-19 03:08:31]

For whom has no solaris stuff, like me, test harnesses in short-mode
on buildbots is the only way to see what's going on.

On Sat, Jan 18, 2014 at 11:00 PM,  <aram@mgk.ro> wrote:
> On 2014/01/16 23:21:12, mikio wrote:
>>
>> Do you want to add solaris port w/o the test harness?
>
>
> What do you mean?
>
>
> https://codereview.appspot.com/53410043/

[aram, 2014-01-19 11:00:24]

On Sun, Jan 19, 2014 at 4:08 AM, Mikio Hara <mikioh.mikioh@gmail.com> wrote:
> For whom has no solaris stuff, like me, test harnesses in short-mode
> on buildbots is the only way to see what's going on.

Understood. FWIW, this passes on Solaris. Perhaps it could be disabled
on Linux only?

-- 
Aram Hăvărneanu

[mikio, 2014-01-19 11:15:17]

On Sun, Jan 19, 2014 at 8:00 PM, Aram Hăvărneanu <aram@mgk.ro> wrote:

> Understood. FWIW, this passes on Solaris.

Thanks.

> Perhaps it could be disabled on Linux only?

Nope, almost all the platforms except Windows and Plan 9.