Issue 5340058: code review 5340058: runtime: add timespec definition for freebsd

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5340058: code review 5340058: runtime: add timespec definition for freebsd (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by jsing

Modified:
12 years, 6 months ago

Reviewers:

CC:
golang-dev, dho

Visibility:
Public.

Description

runtime: add timespec definition for freebsd

Patch Set 1 : diff -r 41171c6b511f https://go.googlecode.com/hg/ #

Patch Set 2 : diff -r 7ea5398e65a5 https://go.googlecode.com/hg/ #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -0 lines)			Patch
M	src/pkg/runtime/freebsd/386/defs.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/freebsd/amd64/defs.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/freebsd/defs.c	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jsing

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 6 months ago (2011-11-08 15:36:49 UTC) #1

dho

LGTM 2011/11/8 <jsing@google.com>: > Reviewers: golang-dev_googlegroups.com, > > Message: > Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), > ...

12 years, 6 months ago (2011-11-08 15:38:55 UTC) #2

LGTM

2011/11/8  <jsing@google.com>:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> runtime: add timespec definition for freebsd
>
> Please review this at http://codereview.appspot.com/5340058/
>
> Affected files:
>  M src/pkg/runtime/freebsd/386/defs.h
>  M src/pkg/runtime/freebsd/amd64/defs.h
>  M src/pkg/runtime/freebsd/defs.c
>
>
> Index: src/pkg/runtime/freebsd/386/defs.h
> ===================================================================
> --- a/src/pkg/runtime/freebsd/386/defs.h
> +++ b/src/pkg/runtime/freebsd/386/defs.h
> @@ -173,6 +173,12 @@
>        byte pad_godefs_0[12];
>  };
>
> +typedef struct Timespec Timespec;
> +struct Timespec {
> +       int32 tv_sec;
> +       int32 tv_nsec;
> +};
> +
>  typedef struct Timeval Timeval;
>  struct Timeval {
>        int32 tv_sec;
> Index: src/pkg/runtime/freebsd/amd64/defs.h
> ===================================================================
> --- a/src/pkg/runtime/freebsd/amd64/defs.h
> +++ b/src/pkg/runtime/freebsd/amd64/defs.h
> @@ -184,6 +184,12 @@
>        byte pad_godefs_0[12];
>  };
>
> +typedef struct Timespec Timespec;
> +struct Timespec {
> +       int64 tv_sec;
> +       int64 tv_nsec;
> +};
> +
>  typedef struct Timeval Timeval;
>  struct Timeval {
>        int64 tv_sec;
> Index: src/pkg/runtime/freebsd/defs.c
> ===================================================================
> --- a/src/pkg/runtime/freebsd/defs.c
> +++ b/src/pkg/runtime/freebsd/defs.c
> @@ -104,5 +104,7 @@
>
>  typedef mcontext_t $Mcontext;
>  typedef ucontext_t $Ucontext;
> +
> +typedef struct timespec $Timespec;
>  typedef struct timeval $Timeval;
>  typedef struct itimerval $Itimerval;
>
>
>

rsc

12 years, 6 months ago (2011-11-08 16:44:04 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=d946ec1f09f6 ***

runtime: add timespec definition for freebsd

R=golang-dev, devon.odell
CC=golang-dev
http://codereview.appspot.com/5340058

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages