Issue 5340041: code review 5340041: gob: fix bug when registering the same type multiple times

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5340041: code review 5340041: gob: fix bug when registering the same type multiple times (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by r

Modified:
13 years, 4 months ago

Reviewers:

CC:
golang-dev, dsymonds, r2

Visibility:
Public.

Description

gob: fix bug when registering the same type multiple times Need to compare user type, not base type.

Patch Set 2 : diff -r 62a88d392930 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 3 : diff -r 62a88d392930 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 62a88d392930 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 322faa43dec6 https://go.googlecode.com/hg/ #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -7 lines)			Patch
	M	src/pkg/encoding/gob/type.go	View	1 2 3	1 chunk	+8 lines, -7 lines	0 comments	Download
	M	src/pkg/encoding/gob/type_test.go	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 4 months ago (2011-11-04 00:52:28 UTC) #1

dsymonds

LGTM http://codereview.appspot.com/5340041/diff/3001/src/pkg/encoding/gob/type.go File src/pkg/encoding/gob/type.go (right): http://codereview.appspot.com/5340041/diff/3001/src/pkg/encoding/gob/type.go#newcode710 src/pkg/encoding/gob/type.go:710: panic("gob: registering duplicate types for " + name) ...

13 years, 4 months ago (2011-11-04 00:54:05 UTC) #2

Hello golang-dev@googlegroups.com, dsymonds@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 4 months ago (2011-11-04 01:01:37 UTC) #3

dsymonds

LGTM If you don't mind importing "log", s/panic(fmt.Sprintf(/log.Panicf/ (and balance parens)

13 years, 4 months ago (2011-11-04 01:03:17 UTC) #4

On Nov 3, 2011, at 6:03 PM, dsymonds@golang.org wrote: > LGTM > > If you ...

13 years, 4 months ago (2011-11-04 01:04:38 UTC) #5

13 years, 4 months ago (2011-11-04 01:05:18 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=4b3f1cb3440e ***

gob: fix bug when registering the same type multiple times
Need to compare user type, not base type.

R=golang-dev, dsymonds, r
CC=golang-dev
http://codereview.appspot.com/5340041

Expand All Messages | Collapse All Messages