Issue 5336045: code review 5336045: os: fixes for error (plan9)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5336045: code review 5336045: os: fixes for error (plan9) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by rsc

Modified:
12 years, 6 months ago

Reviewers:

CC:
adg, golang-dev

Visibility:
Public.

Description

os: fixes for error (plan9) The Plan 9 build stops in runtime, but might as well fix these anyway.

Patch Set 1 #

Patch Set 2 : diff -r 88f724aac26f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 88f724aac26f https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r ecbb6b0e6a69 https://go.googlecode.com/hg/ #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -18 lines)			Patch
M	src/pkg/os/dir_plan9.go	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/pkg/os/env_plan9.go	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/pkg/os/error_plan9.go	View	1	3 chunks	+18 lines, -15 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 6 months ago (2011-11-02 02:18:00 UTC) #1

rsc

12 years, 6 months ago (2011-11-02 02:19:43 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=a71e55d93483 ***

os: fixes for error (plan9)

The Plan 9 build stops in runtime,
but might as well fix these anyway.

R=adg
CC=golang-dev
http://codereview.appspot.com/5336045

Expand All Messages | Collapse All Messages