code review 5336041: cgo: print error instead of panic on undeclared enums/s...

cgo: print error instead of panic on undeclared enums/structs

Types are left as nil if no DWARF information is found and
checking in the rewriting pass so that appropriate errors
with line numbers can be printed.
Fixes issue 2408.

[remyoudompheng, 2011-11-01 08:42:25]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
remy@archlinux.org),

I'd like you to review this change to
https://go.googlecode.com/hg/

[remyoudompheng, 2011-11-03 19:19:07]

On 2011/11/01 08:42:25, remyoudompheng wrote:
> Hello mailto:golang-dev@googlegroups.com (cc:
mailto:golang-dev@googlegroups.com,
> mailto:remy@archlinux.org),
> 
> I'd like you to review this change to
> https://go.googlecode.com/hg/

Any opinion about how to handle the issue?

-- 
Rémy.

[rsc, 2011-11-03 21:24:59]

This is good, thanks.
Could you also add a comment just above the 
new error saying what kind of input provokes it?
Something like

// Use of C.enum_x or C.struct_x without C definition.

http://codereview.appspot.com/5336041/diff/2002/src/cmd/cgo/gcc.go
File src/cmd/cgo/gcc.go (right):

http://codereview.appspot.com/5336041/diff/2002/src/cmd/cgo/gcc.go#newcode669
src/cmd/cgo/gcc.go:669: } else {
Please make this an else if, to keep the errors at the same level of
indentation.

I think I might shorten the error to

error(r.Pos(), "type C.%s: undefined C type %s", r.Name.Go, r.Name.C)

[remyoudompheng, 2011-11-04 22:23:18]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com, remy@archlinux.org),

Please take another look.

[remyoudompheng, 2011-11-04 22:25:27]

Sorry, I thought hg mail would prompt me after complaining gofmt had not been
run.

[remyoudompheng, 2011-11-04 22:26:27]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com, remy@archlinux.org),

Please take another look.

[rsc, 2011-11-07 16:44:27]

Thanks for fixing this.

Please complete a CLA as described at
http://golang.org/doc/contribute.html#copyright

Thanks.
Russ

[remyoudompheng, 2011-11-07 20:03:53]

On 2011/11/07 16:44:27, rsc wrote:
> Thanks for fixing this.
> 
> Please complete a CLA as described at
> http://golang.org/doc/contribute.html#copyright
>

Done.

Regards,
Rémy

[rsc, 2011-11-09 21:01:50]

LGTM

[rsc, 2011-11-09 21:01:57]

*** Submitted as http://code.google.com/p/go/source/detail?r=6b38b2ad3d41 ***

cgo: print error instead of panic on undeclared enums/structs

Types are left as nil if no DWARF information is found and
checking in the rewriting pass so that appropriate errors
with line numbers can be printed.
Fixes issue 2408.

R=rsc
CC=golang-dev, remy
http://codereview.appspot.com/5336041

Committer: Russ Cox <rsc@golang.org>