code review 53350043: syscall: add Flock_t on Linux

syscall: add Flock_t on Linux

Matches Darwin and the BSDs. This means leveldb-go, kv,
Camlistore, etc can stop defining these structs on Linux by
hand.

Update Issue 7059

[bradfitz, 2014-01-16 20:02:23]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[dfc, 2014-01-16 21:09:25]

Please consider adding a test to syscall/consistency_test.go


On Fri, Jan 17, 2014 at 7:02 AM, <bradfitz@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> syscall: add Flock_t on Linux
>
> Matches Darwin and the BSDs. This means leveldb-go, kv,
> Camlistore, etc can stop defining these structs on Linux by
> hand.
>
> Update Issue 7059
>
> Please review this at https://codereview.appspot.com/53350043/
>
> Affected files (+28, -0 lines):
>   M src/pkg/syscall/types_linux.go
>   M src/pkg/syscall/ztypes_linux_386.go
>   M src/pkg/syscall/ztypes_linux_amd64.go
>   M src/pkg/syscall/ztypes_linux_arm.go
>
>
> Index: src/pkg/syscall/types_linux.go
> ===================================================================
> --- a/src/pkg/syscall/types_linux.go
> +++ b/src/pkg/syscall/types_linux.go
> @@ -158,6 +158,8 @@
>
>  type Fsid C.fsid_t
>
> +type Flock_t C.struct_flock
> +
>  // Sockets
>
>  type RawSockaddrInet4 C.struct_sockaddr_in
> Index: src/pkg/syscall/ztypes_linux_386.go
> ===================================================================
> --- a/src/pkg/syscall/ztypes_linux_386.go
> +++ b/src/pkg/syscall/ztypes_linux_386.go
> @@ -142,6 +142,14 @@
>         X__val [2]int32
>  }
>
> +type Flock_t struct {
> +       Type   int16
> +       Whence int16
> +       Start  int64
> +       Len    int64
> +       Pid    int32
> +}
> +
>  type RawSockaddrInet4 struct {
>         Family uint16
>         Port   uint16
> Index: src/pkg/syscall/ztypes_linux_amd64.go
> ===================================================================
> --- a/src/pkg/syscall/ztypes_linux_amd64.go
> +++ b/src/pkg/syscall/ztypes_linux_amd64.go
> @@ -142,6 +142,16 @@
>         X__val [2]int32
>  }
>
> +type Flock_t struct {
> +       Type      int16
> +       Whence    int16
> +       Pad_cgo_0 [4]byte
> +       Start     int64
> +       Len       int64
> +       Pid       int32
> +       Pad_cgo_1 [4]byte
> +}
> +
>  type RawSockaddrInet4 struct {
>         Family uint16
>         Port   uint16
> Index: src/pkg/syscall/ztypes_linux_arm.go
> ===================================================================
> --- a/src/pkg/syscall/ztypes_linux_arm.go
> +++ b/src/pkg/syscall/ztypes_linux_arm.go
> @@ -144,6 +144,14 @@
>         X__val [2]int32
>  }
>
> +type Flock_t struct {
> +       Type   int16
> +       Whence int16
> +       Start  int64
> +       Len    int64
> +       Pid    int32
> +}
> +
>  type RawSockaddrInet4 struct {
>         Family uint16
>         Port   uint16
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[iant, 2014-01-16 21:59:26]

LGTM

[bradfitz, 2014-01-16 22:08:34]

*** Submitted as https://code.google.com/p/go/source/detail?r=9c22c9bc4885 ***

syscall: add Flock_t on Linux

Matches Darwin and the BSDs. This means leveldb-go, kv,
Camlistore, etc can stop defining these structs on Linux by
hand.

Update Issue 7059

R=golang-codereviews, dave, iant
CC=golang-codereviews
https://codereview.appspot.com/53350043