code review 5332048: gc: helpful message instead of internal error on method...

gc: helpful message instead of internal error on method call on pointer to pointer.

Fixes issue 2343.

[lvd, 2011-11-02 16:08:04]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-11-02 16:13:31]

LGTM

http://codereview.appspot.com/5332048/diff/3003/src/cmd/gc/typecheck.c
File src/cmd/gc/typecheck.c (right):

http://codereview.appspot.com/5332048/diff/3003/src/cmd/gc/typecheck.c#newcod...
src/cmd/gc/typecheck.c:1663: } else if(tt->etype == tptr && tt->type->etype ==
tptr &&  eqtype(derefall(tt), rcvr)) {
s/  / /

http://codereview.appspot.com/5332048/diff/3003/src/cmd/gc/typecheck.c#newcod...
src/cmd/gc/typecheck.c:1664: yyerror("calling method %N with receiver %lN
requires explicit dereference.", n->right, n->left);
No trailing period, make look like checklvalue, checkassign etc messages.

yyerror("cannot call method on %lN", n->left);

http://codereview.appspot.com/5332048/diff/3003/test/fixedbugs/bug371.go
File test/fixedbugs/bug371.go (right):

http://codereview.appspot.com/5332048/diff/3003/test/fixedbugs/bug371.go#newc...
test/fixedbugs/bug371.go:1: //  errchk $G $D/$F.go
s/  / / (two space to one)

// errchk ...

// Copyright ...

package main

[lvd, 2011-11-02 16:17:33]

all done & submitting

http://codereview.appspot.com/5332048/diff/3003/src/cmd/gc/typecheck.c
File src/cmd/gc/typecheck.c (right):

http://codereview.appspot.com/5332048/diff/3003/src/cmd/gc/typecheck.c#newcod...
src/cmd/gc/typecheck.c:1663: } else if(tt->etype == tptr && tt->type->etype ==
tptr &&  eqtype(derefall(tt), rcvr)) {
On 2011/11/02 16:13:31, rsc wrote:
> s/  / /

Done.

http://codereview.appspot.com/5332048/diff/3003/src/cmd/gc/typecheck.c#newcod...
src/cmd/gc/typecheck.c:1664: yyerror("calling method %N with receiver %lN
requires explicit dereference.", n->right, n->left);
On 2011/11/02 16:13:31, rsc wrote:
> No trailing period, make look like checklvalue, checkassign etc messages.
> 
> yyerror("cannot call method on %lN", n->left);
> 

Done.

http://codereview.appspot.com/5332048/diff/3003/test/fixedbugs/bug371.go
File test/fixedbugs/bug371.go (right):

http://codereview.appspot.com/5332048/diff/3003/test/fixedbugs/bug371.go#newc...
test/fixedbugs/bug371.go:1: //  errchk $G $D/$F.go
On 2011/11/02 16:13:31, rsc wrote:
> s/  / / (two space to one)
> 
> // errchk ...
> 
> // Copyright ...
> 
> package main

Done.

[lvd, 2011-11-02 16:18:58]

*** Submitted as http://code.google.com/p/go/source/detail?r=b3385d4cb197 ***

gc: helpful message instead of internal error on method call on pointer to
pointer.

Fixes issue 2343.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5332048