Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4084)

Issue 5330069: code review 5330069: gofmt, gofix: sort imports (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by rsc
Modified:
12 years, 5 months ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

gofmt, gofix: sort imports Add ast.SortImports(fset, file) to go/ast, for use by both programs. Fixes issue 346.

Patch Set 1 #

Patch Set 2 : diff -r b3385d4cb197 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b3385d4cb197 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 3dd5a0ccc0e0 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+419 lines, -21 lines) Patch
M src/cmd/gofix/fix.go View 1 2 4 chunks +18 lines, -3 lines 0 comments Download
M src/cmd/gofix/import_test.go View 1 2 2 chunks +30 lines, -0 lines 0 comments Download
M src/cmd/gofix/main.go View 1 2 4 chunks +14 lines, -7 lines 0 comments Download
M src/cmd/gofix/main_test.go View 1 2 3 chunks +4 lines, -9 lines 0 comments Download
M src/cmd/gofix/testdata/reflect.export.go.in View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/gofix/testdata/reflect.export.go.out View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/gofmt/gofmt.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/gofmt/gofmt_test.go View 1 1 chunk +1 line, -0 lines 0 comments Download
A src/cmd/gofmt/testdata/import.golden View 1 2 1 chunk +108 lines, -0 lines 0 comments Download
A src/cmd/gofmt/testdata/import.input View 1 2 1 chunk +108 lines, -0 lines 0 comments Download
M src/pkg/go/ast/Makefile View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A src/pkg/go/ast/import.go View 1 2 3 1 chunk +131 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 5 months ago (2011-11-02 19:29:06 UTC) #1
r
LGTM for gofix i don't know the ast stuff well enough but seems fine too
12 years, 5 months ago (2011-11-02 19:49:38 UTC) #2
rsc
12 years, 5 months ago (2011-11-02 19:54:00 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=5657aeb66f87 ***

gofmt, gofix: sort imports

Add ast.SortImports(fset, file) to go/ast, for use by both programs.

Fixes issue 346.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5330069
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b