Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(232)

Issue 5328062: code review 5328062: all: rename os.Error to error in various non-code contexts (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by rsc
Modified:
12 years, 5 months ago
Reviewers:
CC:
adg, golang-dev
Visibility:
Public.

Description

all: rename os.Error to error in various non-code contexts

Patch Set 1 #

Patch Set 2 : diff -r a71e55d93483 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a71e55d93483 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r a71e55d93483 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r a71e55d93483 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -105 lines) Patch
M doc/codelab/wiki/index.html View 1 8 chunks +8 lines, -8 lines 0 comments Download
M doc/codelab/wiki/wiki.html View 1 8 chunks +8 lines, -8 lines 0 comments Download
M doc/debugging_with_gdb.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/cmd/cgo/out.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/goinstall/main.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/govet/govet.go View 1 2 3 2 chunks +19 lines, -19 lines 0 comments Download
M src/pkg/compress/bzip2/bit_reader.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/crypto/rsa/rsa.go View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/pkg/crypto/tls/conn.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/crypto/x509/verify.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/exp/ssh/channel.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/exp/types/gcimporter.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/fmt/print.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/go/ast/print.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/go/printer/printer.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/go/scanner/errors.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/gob/error.go View 1 2 chunks +5 lines, -5 lines 0 comments Download
M src/pkg/old/netchan/import.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/dir_plan9.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/os/dir_unix.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/file_unix.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/file_windows.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/regexp/all_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/rpc/debug.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/rpc/server.go View 1 6 chunks +12 lines, -13 lines 0 comments Download
M src/pkg/runtime/error.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/smtp/auth.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/tabwriter/tabwriter.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/template/doc.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/template/exec.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/template/exec_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/template/funcs.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/template/helper.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/utf8/string.go View 1 2 2 chunks +4 lines, -16 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 5 months ago (2011-11-02 02:43:03 UTC) #1
adg
LGTM
12 years, 5 months ago (2011-11-02 02:48:30 UTC) #2
rsc
12 years, 5 months ago (2011-11-02 02:58:13 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=085f3ad02135 ***

all: rename os.Error to error in various non-code contexts

R=adg
CC=golang-dev
http://codereview.appspot.com/5328062
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b