Issue 5328051: code review 5328051: test: error-related fixes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5328051: code review 5328051: test: error-related fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by rsc

Modified:
13 years, 5 months ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Patch Set 2 : diff -r eb6fbf796acc https://go.googlecode.com/hg #

Patch Set 3 : diff -r eb6fbf796acc https://go.googlecode.com/hg #

Total comments: 1

Patch Set 4 : diff -r 9ff3b0912866 https://go.googlecode.com/hg #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -11 lines)			Patch
M	test/fixedbugs/bug365.go	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/import.go	View	1 2 3	1 chunk	+3 lines, -4 lines	0 comments	Download
M	test/zerodivide.go	View	1	2 chunks	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg

13 years, 5 months ago (2011-10-28 01:42:35 UTC) #1

bradfitz

LGTM http://codereview.appspot.com/5328051/diff/5001/test/fixedbugs/bug365.go File test/fixedbugs/bug365.go (right): http://codereview.appspot.com/5328051/diff/5001/test/fixedbugs/bug365.go#newcode15 test/fixedbugs/bug365.go:15: err os.Any // ERROR "undefined|expected package" foo.Bar would ...

13 years, 5 months ago (2011-10-28 01:53:21 UTC) #2

rsc

13 years, 5 months ago (2011-10-28 02:41:44 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=b036b65920d2 ***

test: error-related fixes

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5328051

Expand All Messages | Collapse All Messages