Issue 5327048: code review 5327048: go/parser: test and fix := scoping bug

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5327048: code review 5327048: go/parser: test and fix := scoping bug (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by rsc

Modified:
13 years, 5 months ago

Reviewers:

CC:
iant, golang-dev, gri

Visibility:
Public.

Description

go/parser: test and fix := scoping bug

Patch Set 1 #

Patch Set 2 : diff -r 181517df0815 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 181517df0815 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 69423942510b https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -1 line)			Patch
	M	src/pkg/go/parser/parser.go	View	1	3 chunks	+9 lines, -1 line	0 comments	Download
	M	src/pkg/go/parser/parser_test.go	View	1 2	2 chunks	+44 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello iant (cc: golang-dev@googlegroups.com, gri), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2011-10-27 16:22:49 UTC) #1

rsc

13 years, 5 months ago (2011-10-27 19:22:15 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=ac5da9d7a91e ***

go/parser: test and fix := scoping bug

R=iant
CC=golang-dev, gri
http://codereview.appspot.com/5327048

Expand All Messages | Collapse All Messages