Issue 5323071: code review 5323071: gc: package paths in symbol names: don't escape periods...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5323071: code review 5323071: gc: package paths in symbol names: don't escape periods... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by lvd

Modified:
13 years, 4 months ago

Reviewers:
knieriem

CC:
rsc, golang-dev

Visibility:
Public.

Description

gc: package paths in symbol names: don't escape periods before last slash, always escape >=0x7f.

Patch Set 1 #

Patch Set 2 : diff -r 3dd5a0ccc0e0 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3dd5a0ccc0e0 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b9dca3b10c42 https://go.googlecode.com/hg/ #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -6 lines)			Patch
	M	src/cmd/gc/subr.c	View	1	2 chunks	+14 lines, -6 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

lvd

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 4 months ago (2011-11-02 21:24:08 UTC) #1

lvd

*** Submitted as http://code.google.com/p/go/source/detail?r=080e98d350b8 *** gc: package paths in symbol names: don't escape periods before ...

13 years, 4 months ago (2011-11-02 21:33:22 UTC) #3

knieriem

It appears that the patch should be applied to ld/lib.c:pathtoprefix too (there a comment says: ...

13 years, 4 months ago (2011-11-03 16:31:35 UTC) #4

lvd

On Thu, Nov 3, 2011 at 17:31, <mt4swm@googlemail.com> wrote: > It appears that the patch ...

13 years, 4 months ago (2011-11-03 16:32:22 UTC) #5

lvd

13 years, 4 months ago (2011-11-03 16:36:37 UTC) #6

On Thu, Nov 3, 2011 at 17:32, Luuk van Dijk <lvd@google.com> wrote:

>
>
> On Thu, Nov 3, 2011 at 17:31, <mt4swm@googlemail.com> wrote:
>
>> It appears that the patch should be applied to
>> ld/lib.c:pathtoprefix too (there a comment says:
>> Copied from ../gc/subr.c:/^pathtoprefix; must stay in sync.).
>>
>
> woops. will fix asap.
>

http://codereview.appspot.com/5333056


>
>
>>
>> Otherwise programs using packages like go9p.googlecode.com/hg/p
>> won't build. Perhaps the patch for the other file just wasn't uploaded
>> accidentally.
>>
>>
http://codereview.appspot.com/**5323071/<http://codereview.appspot.com/5323071/>
>>
>
>

Expand All Messages | Collapse All Messages