Issue 5323048: code review 5323048: html: improve parsing of tables

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5323048: code review 5323048: html: improve parsing of tables (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by andybalholm

Modified:
12 years, 6 months ago

Reviewers:

CC:
nigeltao, golang-dev

Visibility:
Public.

Description

html: improve parsing of tables When foster parenting, merge adjacent text nodes. Properly close table row at </tr> tag. Pass tests1.dat, test 32: <font><div>hello<table>excite!<b>me!<th><i>please!</tr> |  | <html> | <head> | <body> | <font> | <div> | "helloexcite!" | <b> | "me!" | <table> | <tbody> | <tr> | <th> | <i> | "please!" |

Patch Set 1 #

Patch Set 2 : diff -r e7977be1ca45 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e7977be1ca45 https://go.googlecode.com/hg/ #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -8 lines)			Patch
	M	src/pkg/html/parse.go	View	1	5 chunks	+26 lines, -7 lines	0 comments	Download
	M	src/pkg/html/parse_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

andybalholm

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 6 months ago (2011-10-25 17:09:41 UTC) #1

nigeltao

12 years, 6 months ago (2011-10-26 00:36:56 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=1d7f964dac3a ***

html: improve parsing of tables

When foster parenting, merge adjacent text nodes.
Properly close table row at </tr> tag.

Pass tests1.dat, test 32:
<!-----><font><div>hello<table>excite!<b>me!<th><i>please!</tr><!--X-->

| <!-- - -->
| <html>
|   <head>
|   <body>
|     <font>
|       <div>
|         "helloexcite!"
|         <b>
|           "me!"
|         <table>
|           <tbody>
|             <tr>
|               <th>
|                 <i>
|                   "please!"
|             <!-- X -->

R=nigeltao
CC=golang-dev
http://codereview.appspot.com/5323048

Committer: Nigel Tao <nigeltao@golang.org>

Expand All Messages | Collapse All Messages