code review 5322070: http: only recognize application/x-www-form-urlencoded ...

http: only recognize application/x-www-form-urlencoded in ParseForm

[bradfitz, 2011-11-03 22:36:14]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[dsymonds, 2011-11-03 23:00:11]

Now that I see this, it makes me a little nervous. Modern browsers probably
send the right Content-Type, but there may be ancient browsers that send
nothing, or something weird.

[dsymonds, 2011-11-03 23:02:48]

Maybe a different question: What is the benefit of this change?

[bradfitz, 2011-11-03 23:14:21]

It bit me.  I was sending binary data and was surprised to have it eaten
behind my back when using FormValue (to get a Get parameter, not expecting
it to touch the body)

Your argument says "may" be.  I _was_ bitten.

And "text/plain"?

Let's see what breaks.  It's easy to change back if necessary, but I'll
want a good reason to do so.

The workaround for people who care is to manually set the request's
Content-Type before calling ParseForm.


On Thu, Nov 3, 2011 at 4:02 PM, David Symonds <dsymonds@golang.org> wrote:

> Maybe a different question: What is the benefit of this change?
>

[dsymonds, 2011-11-04 00:02:24]

LGTM

Okay, sounds fine to me, then, especially when there's an easy workaround.

[bradfitz, 2011-11-04 00:22:02]

*** Submitted as http://code.google.com/p/go/source/detail?r=322faa43dec6 ***

http: only recognize application/x-www-form-urlencoded in ParseForm

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/5322070