Issue 5321051: code review 5321051: html: improve parsing of lists

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5321051: code review 5321051: html: improve parsing of lists (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by andybalholm

Modified:
12 years, 6 months ago

Reviewers:

CC:
nigeltao, golang-dev

Visibility:
Public.

Description

html: improve parsing of lists Make a <li> tag close the previous <li> element. Make a </ul> tag close <li> elements. Pass tests1.dat, test 33: <!DOCTYPE html><li>hello<li>world<ul>how<li>do</ul>you</body> | <!DOCTYPE html> | <html> | <head> | <body> | <li> | "hello" | <li> | "world" | <ul> | "how" | <li> | "do" | "you" |

Patch Set 1 #

Patch Set 2 : diff -r 1d7f964dac3a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1d7f964dac3a https://go.googlecode.com/hg/ #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -1 line)			Patch
	M	src/pkg/html/parse.go	View	1	2 chunks	+20 lines, -0 lines	0 comments	Download
	M	src/pkg/html/parse_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

andybalholm

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 6 months ago (2011-10-26 01:06:27 UTC) #1

nigeltao

12 years, 6 months ago (2011-10-26 03:02:45 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=0a7539309b05 ***

html: improve parsing of lists

Make a <li> tag close the previous <li> element.
Make a </ul> tag close <li> elements.

Pass tests1.dat, test 33:
<!DOCTYPE html><li>hello<li>world<ul>how<li>do</ul>you</body><!--do-->

| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     <li>
|       "hello"
|     <li>
|       "world"
|       <ul>
|         "how"
|         <li>
|           "do"
|       "you"
|   <!-- do -->

R=nigeltao
CC=golang-dev
http://codereview.appspot.com/5321051

Committer: Nigel Tao <nigeltao@golang.org>

Expand All Messages | Collapse All Messages