Issue 5321046: code review 5321046: gofix: test import insertion, deletion

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5321046: code review 5321046: gofix: test import insertion, deletion (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by rsc

Modified:
13 years, 5 months ago

Reviewers:

CC:
golang-dev, bradfitz, adg

Visibility:
Public.

Description

gofix: test import insertion, deletion Small change to go/ast, go/parser, go/printer so that gofix can delete the blank line left from deleting an import.

Patch Set 1 #

Patch Set 2 : diff -r 5f5f5be2d47d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3f647c45f84d https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+312 lines, -10 lines)			Patch
M	src/cmd/gofix/fix.go	View	1 2	6 chunks	+33 lines, -8 lines	0 comments	Download
A	src/cmd/gofix/import_test.go	View	1	1 chunk	+269 lines, -0 lines	0 comments	Download
M	src/pkg/go/ast/ast.go	View	1	2 chunks	+8 lines, -1 line	0 comments	Download
M	src/pkg/go/parser/parser.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/go/printer/nodes.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2011-10-25 02:14:07 UTC) #1

rsc

13 years, 5 months ago (2011-10-26 21:04:14 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=d711a8a4b141 ***

gofix: test import insertion, deletion

Small change to go/ast, go/parser, go/printer so that
gofix can delete the blank line left from deleting an import.

R=golang-dev, bradfitz, adg
CC=golang-dev
http://codereview.appspot.com/5321046

Expand All Messages | Collapse All Messages