Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3163)

Issue 5319048: code review 5319048: misc/vim: Add rune keyword

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by Jongmin Kim
Modified:
13 years, 5 months ago
Reviewers:
dsymonds
CC:
adg, dsymonds, golang-dev
Visibility:
Public.

Description

misc/vim: Add rune keyword According to adding rune type

Patch Set 1 #

Patch Set 2 : diff -r c2e852e48194 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c2e852e48194 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M misc/vim/syntax/go.vim View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
Jongmin Kim
Hello adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 5 months ago (2011-10-26 08:56:35 UTC) #1
dsymonds
LGTM
13 years, 5 months ago (2011-10-26 10:10:04 UTC) #2
dsymonds
Can you please fill out the CLA? http://golang.org/doc/contribute.html#copyright
13 years, 5 months ago (2011-10-26 10:47:14 UTC) #3
Jongmin Kim
On 2011/10/26 10:47:14, dsymonds wrote: > Can you please fill out the CLA? > > ...
13 years, 5 months ago (2011-10-26 15:53:52 UTC) #4
dsymonds
13 years, 5 months ago (2011-10-26 22:14:15 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=2434fa505358 ***

misc/vim: Add rune keyword
According to adding rune type

R=adg, dsymonds
CC=golang-dev
http://codereview.appspot.com/5319048

Committer: David Symonds <dsymonds@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b