code review 5316068: tutorial,effective_go: prepare for error change

tutorial,effective_go: prepare for error change

[r, 2011-10-31 20:59:51]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-10-31 21:00:53]

To be submitted after the error changes go in.
The .html files will need to be regenerated before submitting.

[adg, 2011-11-01 00:17:48]

LGTM

http://codereview.appspot.com/5316068/diff/1/doc/go_tutorial.html
File doc/go_tutorial.html (right):

http://codereview.appspot.com/5316068/diff/1/doc/go_tutorial.html#newcode583
doc/go_tutorial.html:583: that make it a good basis for representing and
programming for errors.
s/programming for/handling/ ?

http://codereview.appspot.com/5316068/diff/1/doc/progs/cat.go
File doc/progs/cat.go (right):

http://codereview.appspot.com/5316068/diff/1/doc/progs/cat.go#newcode20
doc/progs/cat.go:20: fmt.Fprintf(os.Stderr, "cat: error reading from %s: %s\n",
f.String(), er)
while you're here, why not remove the .String() from f?

http://codereview.appspot.com/5316068/diff/1/doc/progs/cat_rot13.go
File doc/progs/cat_rot13.go (right):

http://codereview.appspot.com/5316068/diff/1/doc/progs/cat_rot13.go#newcode62
doc/progs/cat_rot13.go:62: fmt.Fprintf(os.Stderr, "cat: error reading from %s:
%s\n", r.String(), er)
ditto

[rsc, 2011-11-01 04:22:55]

LGTM

http://codereview.appspot.com/5316068/diff/1/doc/effective_go.html
File doc/effective_go.html (right):

http://codereview.appspot.com/5316068/diff/1/doc/effective_go.html#newcode2660
doc/effective_go.html:2660: Err error  // Returned by the system call.
add space before //

http://codereview.appspot.com/5316068/diff/1/doc/go_tutorial.html
File doc/go_tutorial.html (right):

http://codereview.appspot.com/5316068/diff/1/doc/go_tutorial.html#newcode583
doc/go_tutorial.html:583: that make it a good basis for representing and
programming for errors.
On 2011/11/01 00:17:48, adg wrote:
> s/programming for/handling/ ?

+1

[rsc, 2011-11-01 05:19:22]

please let me know when this CL is done
so I can patch it into my client and avoid
a repeat of my rune spec mistake.

thanks.

[r, 2011-11-01 15:56:30]

Hello adg@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-11-02 00:46:09]

LGTM

Patching.

[rsc, 2011-11-02 01:50:24]

*** Submitted as http://code.google.com/p/go/source/detail?r=fa6933304838 ***

tutorial,effective_go: prepare for error change

R=adg, rsc
CC=golang-dev
http://codereview.appspot.com/5316068

Committer: Russ Cox <rsc@golang.org>