code review 5314060: gc: fix [568]g -V crash

gc: fix [568]g -V crash

[mikio, 2011-10-26 06:42:58]

Hello dsymonds@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[dsymonds, 2011-10-26 06:53:22]

R=lvd

[mikio, 2011-10-26 06:56:04]

Hello lvd@google.com (cc: golang-dev@googlegroups.com),

Please take another look.

[lvd, 2011-10-26 07:04:41]

LGTM of course

On Wed, Oct 26, 2011 at 08:42, <mikioh.mikioh@gmail.com> wrote:

> Reviewers: dsymonds,
>
> Message:
> Hello dsymonds@golang.org (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> gc: fix [568]g -V crash
>
> Please review this at
http://codereview.appspot.com/**5314060/<http://codereview.appspot.com/5314060/>
>
> Affected files:
>  M src/cmd/gc/lex.c
>
>
> Index: src/cmd/gc/lex.c
> ==============================**==============================**=======
> --- a/src/cmd/gc/lex.c
> +++ b/src/cmd/gc/lex.c
> @@ -229,7 +229,7 @@
>                p = expstring();
>                if(strcmp(p, "X:none") == 0)
>                        p = "";
> -               print("%cg version %s%s%s%s\n", thechar, getgoversion(),
> *p ? " " : "", p);
> +               print("%cg version %s%s%s\n", thechar, getgoversion(), *p
> ? " " : "", p);
>                exits(0);
>        } ARGEND
>
>
>
>

[mikio, 2011-10-26 07:16:52]

*** Submitted as http://code.google.com/p/go/source/detail?r=c2e852e48194 ***

gc: fix [568]g -V crash

R=lvd
CC=golang-dev
http://codereview.appspot.com/5314060