Issue 5311068: code review 5311068: io: use error, add EOF, avoid os

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5311068: code review 5311068: io: use error, add EOF, avoid os (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by rsc

Modified:
13 years, 4 months ago

Reviewers:

CC:
r, r2, golang-dev

Visibility:
Public.

Description

io: use error, add EOF, avoid os

Patch Set 1 #

Patch Set 2 : diff -r a7ee8dfa634d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 26990717694c https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 8f0f154fb94d https://go.googlecode.com/hg/ #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+110 lines, -107 lines)			Patch
M	src/pkg/io/io.go	View	1	25 chunks	+55 lines, -47 lines	0 comments	Download
M	src/pkg/io/io_test.go	View	1	7 chunks	+9 lines, -10 lines	0 comments	Download
M	src/pkg/io/multi.go	View	1	3 chunks	+6 lines, -8 lines	0 comments	Download
M	src/pkg/io/multi_test.go	View	1	3 chunks	+3 lines, -4 lines	0 comments	Download
M	src/pkg/io/pipe.go	View	1	9 chunks	+25 lines, -25 lines	0 comments	Download
M	src/pkg/io/pipe_test.go	View	1	10 chunks	+12 lines, -13 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 4 months ago (2011-10-28 04:04:47 UTC) #1

rsc

13 years, 4 months ago (2011-11-02 01:48:55 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=f751618f828b ***

io: use error, add EOF, avoid os

R=r, r
CC=golang-dev
http://codereview.appspot.com/5311068

Expand All Messages | Collapse All Messages