code review 5311067: pkg: remove .String() from some print arguments

pkg: remove .String() from some print arguments

I found these by adding a check to govet, but the check
produces far too many false positives to be useful.
Even so, these few seem worth cleaning up.

[rsc, 2011-10-27 19:23:47]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-10-27 19:28:59]

LGTM
On Oct 27, 2011 12:23 PM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> pkg: remove .String() from some print arguments
>
> I found these by adding a check to govet, but the check
> produces far too many false positives to be useful.
> Even so, these few seem worth cleaning up.
>
> Please review this at
http://codereview.appspot.com/**5311067/<http://codereview.appspot.com/5311067/>
>
> Affected files:
>  M src/pkg/crypto/bcrypt/bcrypt_**test.go
>  M src/pkg/exp/gui/x11/conn.go
>  M src/pkg/expvar/expvar.go
>  M src/pkg/go/ast/print.go
>  M src/pkg/go/scanner/errors.go
>  M src/pkg/go/scanner/scanner_**test.go
>  M src/pkg/gob/decode.go
>  M src/pkg/gob/encode.go
>  M src/pkg/smtp/smtp_test.go
>  M src/pkg/strconv/fp_test.go
>
>
> Index: src/pkg/crypto/bcrypt/bcrypt_**test.go
> ==============================**==============================**=======
> --- a/src/pkg/crypto/bcrypt/**bcrypt_test.go
> +++ b/src/pkg/crypto/bcrypt/**bcrypt_test.go
> @@ -86,7 +86,7 @@
>                        t.Errorf("%s: Should have returned an error", name)
>                }
>                if err != nil && err != expected {
> -                       t.Errorf("%s gave err %v but should have given
> %v", name, err.String(), expected.String())
> +                       t.Errorf("%s gave err %v but should have given
> %v", name, err, expected)
>                }
>        }
>        for _, iht := range invalidTests {
> Index: src/pkg/exp/gui/x11/conn.go
> ==============================**==============================**=======
> --- a/src/pkg/exp/gui/x11/conn.go
> +++ b/src/pkg/exp/gui/x11/conn.go
> @@ -87,7 +87,7 @@
>                        setU32LE(c.flushBuf0[16:20], uint32(y<<16))
>                        if _, err := c.w.Write(c.flushBuf0[:24]); err !=
> nil {
>                                if err != os.EOF {
> -                                       log.Println("x11:", err.String())
> +                                       log.Println("x11:", err)
>                                }
>                                return
>                        }
> @@ -106,7 +106,7 @@
>                                x += nx
>                                if _, err := c.w.Write(c.flushBuf1[:nx]);
> err != nil {
>                                        if err != os.EOF {
> -                                               log.Println("x11:",
> err.String())
> +                                               log.Println("x11:", err)
>                                        }
>                                        return
>                                }
> @@ -114,7 +114,7 @@
>                }
>                if err := c.w.Flush(); err != nil {
>                        if err != os.EOF {
> -                               log.Println("x11:", err.String())
> +                               log.Println("x11:", err)
>                        }
>                        return
>                }
> Index: src/pkg/expvar/expvar.go
> ==============================**==============================**=======
> --- a/src/pkg/expvar/expvar.go
> +++ b/src/pkg/expvar/expvar.go
> @@ -102,7 +102,7 @@
>                if !first {
>                        fmt.Fprintf(b, ", ")
>                }
> -               fmt.Fprintf(b, "\"%s\": %v", key, val.String())
> +               fmt.Fprintf(b, "\"%s\": %v", key, val)
>                first = false
>        }
>        fmt.Fprintf(b, "}")
> Index: src/pkg/go/ast/print.go
> ==============================**==============================**=======
> --- a/src/pkg/go/ast/print.go
> +++ b/src/pkg/go/ast/print.go
> @@ -149,7 +149,7 @@
>                p.print(x.Elem())
>
>        case reflect.Map:
> -               p.printf("%s (len = %d) {\n", x.Type().String(), x.Len())
> +               p.printf("%s (len = %d) {\n", x.Type(), x.Len())
>                p.indent++
>                for _, key := range x.MapKeys() {
>                        p.print(key)
> @@ -178,7 +178,7 @@
>                        p.printf("%#q", s)
>                        return
>                }
> -               p.printf("%s (len = %d) {\n", x.Type().String(), x.Len())
> +               p.printf("%s (len = %d) {\n", x.Type(), x.Len())
>                p.indent++
>                for i, n := 0, x.Len(); i < n; i++ {
>                        p.printf("%d: ", i)
> @@ -189,7 +189,7 @@
>                p.printf("}")
>
>        case reflect.Struct:
> -               p.printf("%s {\n", x.Type().String())
> +               p.printf("%s {\n", x.Type())
>                p.indent++
>                t := x.Type()
>                for i, n := 0, t.NumField(); i < n; i++ {
> Index: src/pkg/go/scanner/errors.go
> ==============================**==============================**=======
> --- a/src/pkg/go/scanner/errors.go
> +++ b/src/pkg/go/scanner/errors.go
> @@ -92,7 +92,7 @@
>        case 1:
>                return p[0].String()
>        }
> -       return fmt.Sprintf("%s (and %d more errors)", p[0].String(),
> len(p)-1)
> +       return fmt.Sprintf("%s (and %d more errors)", p[0], len(p)-1)
>  }
>
>  // These constants control the construction of the ErrorList
> Index: src/pkg/go/scanner/scanner_**test.go
> ==============================**==============================**=======
> --- a/src/pkg/go/scanner/scanner_**test.go
> +++ b/src/pkg/go/scanner/scanner_**test.go
> @@ -237,7 +237,7 @@
>                }
>                checkPos(t, lit, pos, epos)
>                if tok != e.tok {
> -                       t.Errorf("bad token for %q: got %s, expected %s",
> lit, tok.String(), e.tok.String())
> +                       t.Errorf("bad token for %q: got %s, expected %s",
> lit, tok, e.tok)
>                }
>                if e.tok.IsLiteral() && lit != e.lit {
>                        t.Errorf("bad literal for %q: got %q, expected %q",
> lit, lit, e.lit)
> @@ -286,7 +286,7 @@
>                                }
>                                checkPos(t, line, pos, semiPos)
>                        } else {
> -                               t.Errorf("bad token for %q: got %s,
> expected ;", line, tok.String())
> +                               t.Errorf("bad token for %q: got %s,
> expected ;", line, tok)
>                        }
>                } else if tok == token.SEMICOLON {
>                        t.Errorf("bad token for %q: got ;, expected no ;",
> line)
> @@ -509,7 +509,7 @@
>        s.Scan()              // true
>        _, tok, _ := s.Scan() // {
>        if tok != token.LBRACE {
> -               t.Errorf("bad token: got %s, expected %s", tok.String(),
> token.LBRACE)
> +               t.Errorf("bad token: got %s, expected %s", tok,
> token.LBRACE)
>        }
>
>        // 2nd init
> @@ -521,7 +521,7 @@
>        }
>        _, tok, _ = s.Scan() // go
>        if tok != token.GO {
> -               t.Errorf("bad token: got %s, expected %s", tok.String(),
> token.GO)
> +               t.Errorf("bad token: got %s, expected %s", tok, token.GO)
>        }
>
>        if s.ErrorCount != 0 {
> Index: src/pkg/gob/decode.go
> ==============================**==============================**=======
> --- a/src/pkg/gob/decode.go
> +++ b/src/pkg/gob/decode.go
> @@ -881,7 +881,7 @@
>                }
>        }
>        if op == nil {
> -               errorf("decode can't handle type %s", rt.String())
> +               errorf("decode can't handle type %s", rt)
>        }
>        return &op, indir
>  }
> @@ -1110,7 +1110,7 @@
>                wireStruct = wire.StructT
>        }
>        if wireStruct == nil {
> -               errorf("type mismatch in decoder: want struct type %s; got
> non-struct", rt.String())
> +               errorf("type mismatch in decoder: want struct type %s; got
> non-struct", rt)
>        }
>        engine = new(decEngine)
>        engine.instr = make([]decInstr, len(wireStruct.Field))
> Index: src/pkg/gob/encode.go
> ==============================**==============================**=======
> --- a/src/pkg/gob/encode.go
> +++ b/src/pkg/gob/encode.go
> @@ -610,7 +610,7 @@
>                }
>        }
>        if op == nil {
> -               errorf("can't happen: encode type %s", rt.String())
> +               errorf("can't happen: encode type %s", rt)
>        }
>        return &op, indir
>  }
> Index: src/pkg/smtp/smtp_test.go
> ==============================**==============================**=======
> --- a/src/pkg/smtp/smtp_test.go
> +++ b/src/pkg/smtp/smtp_test.go
> @@ -37,14 +37,14 @@
>                        t.Errorf("#%d got response %s, expected %s", i,
> resp, test.responses[0])
>                }
>                if err != nil {
> -                       t.Errorf("#%d error: %s", i, err.String())
> +                       t.Errorf("#%d error: %s", i, err)
>                }
>                for j := range test.challenges {
>                        challenge := []byte(test.challenges[j])
>                        expected := []byte(test.responses[j+1])
>                        resp, err := test.auth.Next(challenge, true)
>                        if err != nil {
> -                               t.Errorf("#%d error: %s", i, err.String())
> +                               t.Errorf("#%d error: %s", i, err)
>                                continue testLoop
>                        }
>                        if !bytes.Equal(resp, expected) {
> @@ -74,13 +74,13 @@
>        c := &Client{Text: textproto.NewConn(fake)}
>
>        if err := c.helo(); err != nil {
> -               t.Fatalf("HELO failed: %s", err.String())
> +               t.Fatalf("HELO failed: %s", err)
>        }
>        if err := c.ehlo(); err == nil {
>                t.Fatalf("Expected first EHLO to fail")
>        }
>        if err := c.ehlo(); err != nil {
> -               t.Fatalf("Second EHLO failed: %s", err.String())
> +               t.Fatalf("Second EHLO failed: %s", err)
>        }
>
>        if ok, args := c.Extension("aUtH"); !ok || args != "LOGIN PLAIN" {
> @@ -105,14 +105,14 @@
>        c.tls = true
>        c.serverName = "smtp.google.com"
>        if err := c.Auth(PlainAuth("", "user", "pass", "smtp.google.com"));
> err != nil {
> -               t.Fatalf("AUTH failed: %s", err.String())
> +               t.Fatalf("AUTH failed: %s", err)
>        }
>
>        if err := c.Mail("user@gmail.com"); err != nil {
> -               t.Fatalf("MAIL failed: %s", err.String())
> +               t.Fatalf("MAIL failed: %s", err)
>        }
>        if err :=
c.Rcpt("golang-nuts@**googlegroups.com<golang-nuts@googlegroups.com>");
> err != nil {
> -               t.Fatalf("RCPT failed: %s", err.String())
> +               t.Fatalf("RCPT failed: %s", err)
>        }
>        msg := `From: user@gmail.com
>  To: golang-nuts@googlegroups.com
> @@ -123,17 +123,17 @@
>  Goodbye.`
>        w, err := c.Data()
>        if err != nil {
> -               t.Fatalf("DATA failed: %s", err.String())
> +               t.Fatalf("DATA failed: %s", err)
>        }
>        if _, err := w.Write([]byte(msg)); err != nil {
> -               t.Fatalf("Data write failed: %s", err.String())
> +               t.Fatalf("Data write failed: %s", err)
>        }
>        if err := w.Close(); err != nil {
> -               t.Fatalf("Bad data response: %s", err.String())
> +               t.Fatalf("Bad data response: %s", err)
>        }
>
>        if err := c.Quit(); err != nil {
> -               t.Fatalf("QUIT failed: %s", err.String())
> +               t.Fatalf("QUIT failed: %s", err)
>        }
>
>        bcmdbuf.Flush()
> Index: src/pkg/strconv/fp_test.go
> ==============================**==============================**=======
> --- a/src/pkg/strconv/fp_test.go
> +++ b/src/pkg/strconv/fp_test.go
> @@ -96,7 +96,7 @@
>  func TestFp(t *testing.T) {
>        f, err := os.Open("testfp.txt")
>        if err != nil {
> -               t.Fatal("testfp: open testfp.txt:", err.String())
> +               t.Fatal("testfp: open testfp.txt:", err)
>        }
>        defer f.Close()
>
>
>
>

[iant2, 2011-10-27 19:42:27]

LGTM

rsc@golang.org writes:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> pkg: remove .String() from some print arguments
>
> I found these by adding a check to govet, but the check
> produces far too many false positives to be useful.
> Even so, these few seem worth cleaning up.
>
> Please review this at http://codereview.appspot.com/5311067/
>
> Affected files:
>   M src/pkg/crypto/bcrypt/bcrypt_test.go
>   M src/pkg/exp/gui/x11/conn.go
>   M src/pkg/expvar/expvar.go
>   M src/pkg/go/ast/print.go
>   M src/pkg/go/scanner/errors.go
>   M src/pkg/go/scanner/scanner_test.go
>   M src/pkg/gob/decode.go
>   M src/pkg/gob/encode.go
>   M src/pkg/smtp/smtp_test.go
>   M src/pkg/strconv/fp_test.go
>
>
> Index: src/pkg/crypto/bcrypt/bcrypt_test.go
> ===================================================================
> --- a/src/pkg/crypto/bcrypt/bcrypt_test.go
> +++ b/src/pkg/crypto/bcrypt/bcrypt_test.go
> @@ -86,7 +86,7 @@
>  			t.Errorf("%s: Should have returned an error", name)
>  		}
>  		if err != nil && err != expected {
> -			t.Errorf("%s gave err %v but should have given
> %v", name, err.String(), expected.String())
> +			t.Errorf("%s gave err %v but should have given %v", name, err, expected)
>  		}
>  	}
>  	for _, iht := range invalidTests {
> Index: src/pkg/exp/gui/x11/conn.go
> ===================================================================
> --- a/src/pkg/exp/gui/x11/conn.go
> +++ b/src/pkg/exp/gui/x11/conn.go
> @@ -87,7 +87,7 @@
>  			setU32LE(c.flushBuf0[16:20], uint32(y<<16))
>  			if _, err := c.w.Write(c.flushBuf0[:24]); err != nil {
>  				if err != os.EOF {
> -					log.Println("x11:", err.String())
> +					log.Println("x11:", err)
>  				}
>  				return
>  			}
> @@ -106,7 +106,7 @@
>  				x += nx
>  				if _, err := c.w.Write(c.flushBuf1[:nx]); err != nil {
>  					if err != os.EOF {
> -						log.Println("x11:", err.String())
> +						log.Println("x11:", err)
>  					}
>  					return
>  				}
> @@ -114,7 +114,7 @@
>  		}
>  		if err := c.w.Flush(); err != nil {
>  			if err != os.EOF {
> -				log.Println("x11:", err.String())
> +				log.Println("x11:", err)
>  			}
>  			return
>  		}
> Index: src/pkg/expvar/expvar.go
> ===================================================================
> --- a/src/pkg/expvar/expvar.go
> +++ b/src/pkg/expvar/expvar.go
> @@ -102,7 +102,7 @@
>  		if !first {
>  			fmt.Fprintf(b, ", ")
>  		}
> -		fmt.Fprintf(b, "\"%s\": %v", key, val.String())
> +		fmt.Fprintf(b, "\"%s\": %v", key, val)
>  		first = false
>  	}
>  	fmt.Fprintf(b, "}")
> Index: src/pkg/go/ast/print.go
> ===================================================================
> --- a/src/pkg/go/ast/print.go
> +++ b/src/pkg/go/ast/print.go
> @@ -149,7 +149,7 @@
>  		p.print(x.Elem())
>
>  	case reflect.Map:
> -		p.printf("%s (len = %d) {\n", x.Type().String(), x.Len())
> +		p.printf("%s (len = %d) {\n", x.Type(), x.Len())
>  		p.indent++
>  		for _, key := range x.MapKeys() {
>  			p.print(key)
> @@ -178,7 +178,7 @@
>  			p.printf("%#q", s)
>  			return
>  		}
> -		p.printf("%s (len = %d) {\n", x.Type().String(), x.Len())
> +		p.printf("%s (len = %d) {\n", x.Type(), x.Len())
>  		p.indent++
>  		for i, n := 0, x.Len(); i < n; i++ {
>  			p.printf("%d: ", i)
> @@ -189,7 +189,7 @@
>  		p.printf("}")
>
>  	case reflect.Struct:
> -		p.printf("%s {\n", x.Type().String())
> +		p.printf("%s {\n", x.Type())
>  		p.indent++
>  		t := x.Type()
>  		for i, n := 0, t.NumField(); i < n; i++ {
> Index: src/pkg/go/scanner/errors.go
> ===================================================================
> --- a/src/pkg/go/scanner/errors.go
> +++ b/src/pkg/go/scanner/errors.go
> @@ -92,7 +92,7 @@
>  	case 1:
>  		return p[0].String()
>  	}
> -	return fmt.Sprintf("%s (and %d more errors)", p[0].String(), len(p)-1)
> +	return fmt.Sprintf("%s (and %d more errors)", p[0], len(p)-1)
>  }
>
>  // These constants control the construction of the ErrorList
> Index: src/pkg/go/scanner/scanner_test.go
> ===================================================================
> --- a/src/pkg/go/scanner/scanner_test.go
> +++ b/src/pkg/go/scanner/scanner_test.go
> @@ -237,7 +237,7 @@
>  		}
>  		checkPos(t, lit, pos, epos)
>  		if tok != e.tok {
> -			t.Errorf("bad token for %q: got %s, expected
> %s", lit, tok.String(), e.tok.String())
> +			t.Errorf("bad token for %q: got %s, expected %s", lit, tok, e.tok)
>  		}
>  		if e.tok.IsLiteral() && lit != e.lit {
>  			t.Errorf("bad literal for %q: got %q, expected %q", lit, lit, e.lit)
> @@ -286,7 +286,7 @@
>  				}
>  				checkPos(t, line, pos, semiPos)
>  			} else {
> -				t.Errorf("bad token for %q: got %s, expected ;", line, tok.String())
> +				t.Errorf("bad token for %q: got %s, expected ;", line, tok)
>  			}
>  		} else if tok == token.SEMICOLON {
>  			t.Errorf("bad token for %q: got ;, expected no ;", line)
> @@ -509,7 +509,7 @@
>  	s.Scan()              // true
>  	_, tok, _ := s.Scan() // {
>  	if tok != token.LBRACE {
> -		t.Errorf("bad token: got %s, expected %s", tok.String(), token.LBRACE)
> +		t.Errorf("bad token: got %s, expected %s", tok, token.LBRACE)
>  	}
>
>  	// 2nd init
> @@ -521,7 +521,7 @@
>  	}
>  	_, tok, _ = s.Scan() // go
>  	if tok != token.GO {
> -		t.Errorf("bad token: got %s, expected %s", tok.String(), token.GO)
> +		t.Errorf("bad token: got %s, expected %s", tok, token.GO)
>  	}
>
>  	if s.ErrorCount != 0 {
> Index: src/pkg/gob/decode.go
> ===================================================================
> --- a/src/pkg/gob/decode.go
> +++ b/src/pkg/gob/decode.go
> @@ -881,7 +881,7 @@
>  		}
>  	}
>  	if op == nil {
> -		errorf("decode can't handle type %s", rt.String())
> +		errorf("decode can't handle type %s", rt)
>  	}
>  	return &op, indir
>  }
> @@ -1110,7 +1110,7 @@
>  		wireStruct = wire.StructT
>  	}
>  	if wireStruct == nil {
> -		errorf("type mismatch in decoder: want struct type %s;
> got non-struct", rt.String())
> +		errorf("type mismatch in decoder: want struct type %s;
> got non-struct", rt)
>  	}
>  	engine = new(decEngine)
>  	engine.instr = make([]decInstr, len(wireStruct.Field))
> Index: src/pkg/gob/encode.go
> ===================================================================
> --- a/src/pkg/gob/encode.go
> +++ b/src/pkg/gob/encode.go
> @@ -610,7 +610,7 @@
>  		}
>  	}
>  	if op == nil {
> -		errorf("can't happen: encode type %s", rt.String())
> +		errorf("can't happen: encode type %s", rt)
>  	}
>  	return &op, indir
>  }
> Index: src/pkg/smtp/smtp_test.go
> ===================================================================
> --- a/src/pkg/smtp/smtp_test.go
> +++ b/src/pkg/smtp/smtp_test.go
> @@ -37,14 +37,14 @@
>  			t.Errorf("#%d got response %s, expected %s", i, resp, test.responses[0])
>  		}
>  		if err != nil {
> -			t.Errorf("#%d error: %s", i, err.String())
> +			t.Errorf("#%d error: %s", i, err)
>  		}
>  		for j := range test.challenges {
>  			challenge := []byte(test.challenges[j])
>  			expected := []byte(test.responses[j+1])
>  			resp, err := test.auth.Next(challenge, true)
>  			if err != nil {
> -				t.Errorf("#%d error: %s", i, err.String())
> +				t.Errorf("#%d error: %s", i, err)
>  				continue testLoop
>  			}
>  			if !bytes.Equal(resp, expected) {
> @@ -74,13 +74,13 @@
>  	c := &Client{Text: textproto.NewConn(fake)}
>
>  	if err := c.helo(); err != nil {
> -		t.Fatalf("HELO failed: %s", err.String())
> +		t.Fatalf("HELO failed: %s", err)
>  	}
>  	if err := c.ehlo(); err == nil {
>  		t.Fatalf("Expected first EHLO to fail")
>  	}
>  	if err := c.ehlo(); err != nil {
> -		t.Fatalf("Second EHLO failed: %s", err.String())
> +		t.Fatalf("Second EHLO failed: %s", err)
>  	}
>
>  	if ok, args := c.Extension("aUtH"); !ok || args != "LOGIN PLAIN" {
> @@ -105,14 +105,14 @@
>  	c.tls = true
>  	c.serverName = "smtp.google.com"
>  	if err := c.Auth(PlainAuth("", "user", "pass",
> "smtp.google.com")); err != nil {
> -		t.Fatalf("AUTH failed: %s", err.String())
> +		t.Fatalf("AUTH failed: %s", err)
>  	}
>
>  	if err := c.Mail("user@gmail.com"); err != nil {
> -		t.Fatalf("MAIL failed: %s", err.String())
> +		t.Fatalf("MAIL failed: %s", err)
>  	}
>  	if err := c.Rcpt("golang-nuts@googlegroups.com"); err != nil {
> -		t.Fatalf("RCPT failed: %s", err.String())
> +		t.Fatalf("RCPT failed: %s", err)
>  	}
>  	msg := `From: user@gmail.com
>  To: golang-nuts@googlegroups.com
> @@ -123,17 +123,17 @@
>  Goodbye.`
>  	w, err := c.Data()
>  	if err != nil {
> -		t.Fatalf("DATA failed: %s", err.String())
> +		t.Fatalf("DATA failed: %s", err)
>  	}
>  	if _, err := w.Write([]byte(msg)); err != nil {
> -		t.Fatalf("Data write failed: %s", err.String())
> +		t.Fatalf("Data write failed: %s", err)
>  	}
>  	if err := w.Close(); err != nil {
> -		t.Fatalf("Bad data response: %s", err.String())
> +		t.Fatalf("Bad data response: %s", err)
>  	}
>
>  	if err := c.Quit(); err != nil {
> -		t.Fatalf("QUIT failed: %s", err.String())
> +		t.Fatalf("QUIT failed: %s", err)
>  	}
>
>  	bcmdbuf.Flush()
> Index: src/pkg/strconv/fp_test.go
> ===================================================================
> --- a/src/pkg/strconv/fp_test.go
> +++ b/src/pkg/strconv/fp_test.go
> @@ -96,7 +96,7 @@
>  func TestFp(t *testing.T) {
>  	f, err := os.Open("testfp.txt")
>  	if err != nil {
> -		t.Fatal("testfp: open testfp.txt:", err.String())
> +		t.Fatal("testfp: open testfp.txt:", err)
>  	}
>  	defer f.Close()

[rsc, 2011-10-28 01:03:58]

*** Submitted as http://code.google.com/p/go/source/detail?r=738f105abf75 ***

pkg: remove .String() from some print arguments

I found these by adding a check to govet, but the check
produces far too many false positives to be useful.
Even so, these few seem worth cleaning up.

R=golang-dev, bradfitz, iant
CC=golang-dev
http://codereview.appspot.com/5311067