Issue 5311066: code review 5311066: html: allow whitespace text nodes in <head>

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5311066: code review 5311066: html: allow whitespace text nodes in <head> (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by andybalholm

Modified:
13 years, 5 months ago

Reviewers:
nigeltao

CC:
golang-dev

Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : diff -r 69423942510b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 69423942510b https://go.googlecode.com/hg/ #

Total comments: 1

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -3 lines)			Patch
	M	src/pkg/html/parse.go	View	1	4 chunks	+16 lines, -2 lines	1 comment	Download
	M	src/pkg/html/parse_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

andybalholm

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2011-10-27 15:51:11 UTC) #1

nigeltao

*** Submitted as http://code.google.com/p/go/source/detail?r=eb6fbf796acc *** html: allow whitespace text nodes in <head> Pass tests1.dat, test ...

13 years, 5 months ago (2011-10-27 22:06:34 UTC) #3

nigeltao

13 years, 5 months ago (2011-10-27 22:18:18 UTC) #4

LGTM.

http://codereview.appspot.com/5311066/diff/5001/src/pkg/html/parse.go
File src/pkg/html/parse.go (right):

http://codereview.appspot.com/5311066/diff/5001/src/pkg/html/parse.go#newcode443
src/pkg/html/parse.go:443: case TextToken:
I moved this to be below the ErrorToken case, and submitted.

Expand All Messages | Collapse All Messages