Issue 5311063: code review 5311063: html: close <option> element when opening <optgroup>

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5311063: code review 5311063: html: close <option> element when opening <optgroup> (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by andybalholm

Modified:
13 years, 5 months ago

Reviewers:

CC:
nigeltao, golang-dev

Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : diff -r 3fe4f3f34e9b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3fe4f3f34e9b https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	src/pkg/html/parse.go	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
	M	src/pkg/html/parse_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

andybalholm

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2011-10-26 16:55:51 UTC) #1

nigeltao

LGTM. I'll update the CL description to also say the last test case that now ...

13 years, 5 months ago (2011-10-26 22:39:35 UTC) #2

nigeltao

13 years, 5 months ago (2011-10-26 22:45:55 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=cd9ad9e8d249 ***

html: close <option> element when opening <optgroup>

Pass tests1.dat, test 34:
<!DOCTYPE html>A<option>B<optgroup>C<select>D</option>E

| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     "A"
|     <option>
|       "B"
|     <optgroup>
|       "C"
|       <select>
|         "DE"

Also passes tests 35-48. Test 48 is:
</ COM--MENT >

R=nigeltao
CC=golang-dev
http://codereview.appspot.com/5311063

Committer: Nigel Tao <nigeltao@golang.org>

Expand All Messages | Collapse All Messages