code review 5309042: exp/norm: use rune

exp/norm: use rune

Nothing terribly interesting here. (!)

Since the public APIs are all in terms of UTF-8,
the changes are all internal only.

[rsc, 2011-10-19 17:27:25]

Hello mpvl (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[gri, 2011-10-19 18:25:47]

LGTM

http://codereview.appspot.com/5309042/diff/5001/src/pkg/exp/norm/maketables.go
File src/pkg/exp/norm/maketables.go (right):

http://codereview.appspot.com/5309042/diff/5001/src/pkg/exp/norm/maketables.g...
src/pkg/exp/norm/maketables.go:163: var lastChar rune = 0
perhaps:

var lastChar = rune('\x00')

and then we might be able to get rid of the conversion eventually

[r, 2011-10-19 18:26:13]

LGTM

[rsc, 2011-10-19 19:04:37]

On Oct 19, 2011 at 14:25, gri@golang.org wrote:
> src/pkg/exp/norm/maketables.go:163: var lastChar rune = 0
> perhaps:
> 
> var lastChar = rune('\x00')
> 
> and then we might be able to get rid of the conversion eventually

Done.  I've been using \u0000 instead, for Unicode code points.

[mpvl, 2011-10-20 16:17:08]

LGTM

http://codereview.appspot.com/5309042/diff/8001/src/pkg/exp/norm/normregtest.go
File src/pkg/exp/norm/normregtest.go (right):

http://codereview.appspot.com/5309042/diff/8001/src/pkg/exp/norm/normregtest....
src/pkg/exp/norm/normregtest.go:106: r      int                 // used for
character by character test
int -> rune?

[rsc, 2011-10-26 05:26:17]

*** Submitted as http://code.google.com/p/go/source/detail?r=8ed86d2166d2 ***

exp/norm: use rune

Nothing terribly interesting here. (!)

Since the public APIs are all in terms of UTF-8,
the changes are all internal only.

R=mpvl, gri, r
CC=golang-dev
http://codereview.appspot.com/5309042