code review 5307066: non-pkg: gofix -r error

non-pkg: gofix -r error -force=error

[rsc, 2011-10-28 04:06:09]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
FAKE_REPOSITORY

[iant, 2011-10-28 15:51:09]

LGTM modulo comments below.

http://codereview.appspot.com/5307066/diff/2001/doc/progs/helloworld3.go
File doc/progs/helloworld3.go (right):

http://codereview.appspot.com/5307066/diff/2001/doc/progs/helloworld3.go#newc...
doc/progs/helloworld3.go:18: fmt.Printf("can't open file; err=%s\n",
err.Error())
Could just s/err.Error()/err/ here.  Something to consider in the context of the
tutorial, I guess.

http://codereview.appspot.com/5307066/diff/2001/lib/codereview/codereview.py
File lib/codereview/codereview.py (right):

http://codereview.appspot.com/5307066/diff/2001/lib/codereview/codereview.py#...
lib/codereview/codereview.py:1: # coding=utf-8
I assume this file is not really supposed to be part of this CL.

http://codereview.appspot.com/5307066/diff/2001/src/cmd/gofix/math.go
File src/cmd/gofix/math.go (right):

http://codereview.appspot.com/5307066/diff/2001/src/cmd/gofix/math.go#newcode13
src/cmd/gofix/math.go:13: var _ error
This line has become useless.

http://codereview.appspot.com/5307066/diff/2001/src/cmd/gofix/url.go
File src/cmd/gofix/url.go (right):

http://codereview.appspot.com/5307066/diff/2001/src/cmd/gofix/url.go#newcode13
src/cmd/gofix/url.go:13: var _ error
This line has become useless.

http://codereview.appspot.com/5307066/diff/2001/test/fixedbugs/bug107.go
File test/fixedbugs/bug107.go (right):

http://codereview.appspot.com/5307066/diff/2001/test/fixedbugs/bug107.go#newc...
test/fixedbugs/bug107.go:9: type _ error
This is the wrong change for this test of erroneous code.  We want to keep the
import of "os", and do something like

type _ os.Process

[r, 2011-10-31 20:02:43]

again, the tutorial changes are incomplete
ditto for

[r2, 2011-10-31 20:03:09]

/ditto for/d

[rsc, 2011-10-31 20:48:17]

On Mon, Oct 31, 2011 at 16:02,  <r@golang.org> wrote:
> again, the tutorial changes are incomplete

Yes, they are.  This is a completely automatic CL,
which I plan to regenerate from tip when the time
comes.  I would like to leave the doc changes for
a future CL (and future weekly).

Russ

[rsc, 2011-10-31 20:49:59]

On Fri, Oct 28, 2011 at 11:51,  <iant@golang.org> wrote:
>
http://codereview.appspot.com/5307066/diff/2001/doc/progs/helloworld3.go#newc...
> doc/progs/helloworld3.go:18: fmt.Printf("can't open file; err=%s\n",
> err.Error())
> Could just s/err.Error()/err/ here.  Something to consider in the
> context of the tutorial, I guess.

Yes, I decided to leave that for the tutorial.

>
http://codereview.appspot.com/5307066/diff/2001/lib/codereview/codereview.py#...
> lib/codereview/codereview.py:1: # coding=utf-8
> I assume this file is not really supposed to be part of this CL.

Yes.

>
http://codereview.appspot.com/5307066/diff/2001/src/cmd/gofix/math.go#newcode13
> src/cmd/gofix/math.go:13: var _ error
> This line has become useless.
>
> http://codereview.appspot.com/5307066/diff/2001/src/cmd/gofix/url.go#newcode13
> src/cmd/gofix/url.go:13: var _ error
> This line has become useless.

I've updated these in the gofix CL (which will take
precedence) to just delete them.  They are debugging dregs.

>
http://codereview.appspot.com/5307066/diff/2001/test/fixedbugs/bug107.go#newc...
> test/fixedbugs/bug107.go:9: type _ error
> This is the wrong change for this test of erroneous code.  We want to
> keep the import of "os", and do something like
>
> type _ os.Process

Nice catch.  Sent 5306087.

Russ

[rsc, 2011-11-02 02:06:09]

*** Submitted as http://code.google.com/p/go/source/detail?r=d5461f77d8f1 ***

non-pkg: gofix -r error -force=error

R=golang-dev, iant, r, r
CC=golang-dev
http://codereview.appspot.com/5307066