Issue 5306092: code review 5306092: gofix: make fix order implicit by date.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5306092: code review 5306092: gofix: make fix order implicit by date. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by dsymonds

Modified:
13 years, 4 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

gofix: make fix order implicit by date. This partially undoes 8fd7e6d070c8, but preserves its semantics. More importantly, it results in the data about each fix being decentralised, which makes it easier for new fixes to be added, and other gofix users to slot new fixes in. It also adds some useful metadata that could be used in the future.

Patch Set 1 #

Patch Set 2 : diff -r e6a7e56f806b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e6a7e56f806b https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r d878b6a5a788 https://go.googlecode.com/hg/ #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+131 lines, -35 lines)			Patch
M	src/cmd/gofix/error.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/cmd/gofix/filepath.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/cmd/gofix/fix.go	View	1	1 chunk	+17 lines, -33 lines	0 comments	Download
M	src/cmd/gofix/httpfinalurl.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/cmd/gofix/httpfs.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/cmd/gofix/httpheaders.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/cmd/gofix/httpserver.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/cmd/gofix/imagecolor.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/cmd/gofix/imagenew.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/cmd/gofix/iocopyn.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/cmd/gofix/main.go	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/cmd/gofix/mapdelete.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/cmd/gofix/math.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/cmd/gofix/netdial.go	View	1	3 chunks	+9 lines, -0 lines	0 comments	Download
M	src/cmd/gofix/netudpgroup.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/cmd/gofix/oserrorstring.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/cmd/gofix/osopen.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/cmd/gofix/procattr.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/cmd/gofix/reflect.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/cmd/gofix/signal.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/cmd/gofix/sorthelpers.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/cmd/gofix/sortslice.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/cmd/gofix/stringssplit.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/cmd/gofix/url.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 4 months ago (2011-11-03 00:37:51 UTC) #1

dsymonds

13 years, 4 months ago (2011-11-03 21:34:45 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=ad9821161b3e ***

gofix: make fix order implicit by date.

This partially undoes 8fd7e6d070c8, but preserves its semantics.
More importantly, it results in the data about each fix being
decentralised, which makes it easier for new fixes to be added,
and other gofix users to slot new fixes in.

It also adds some useful metadata that could be used in the future.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5306092

Expand All Messages | Collapse All Messages