Issue 5305084: code review 5305084: rpc: avoid infinite loop on input error

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5305084: code review 5305084: rpc: avoid infinite loop on input error (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by rsc

Modified:
13 years, 5 months ago

Reviewers:
rog

CC:
golang-dev, r

Visibility:
Public.

Description

rpc: avoid infinite loop on input error Fixes issue 1828. Fixes issue 2179.

Patch Set 1 #

Patch Set 2 : diff -r 5111c850d855 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 5111c850d855 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 761ef67b1235 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 39729c81e276 https://go.googlecode.com/hg/ #

Total comments: 1

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -9 lines)			Patch
M	src/pkg/rpc/jsonrpc/all_test.go	View	1 2	2 chunks	+65 lines, -0 lines	0 comments	Download
M	src/pkg/rpc/server.go	View	1	5 chunks	+12 lines, -8 lines	1 comment	Download
M	src/pkg/rpc/server_test.go	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2011-11-01 03:50:38 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=72cf9d58c08f *** rpc: avoid infinite loop on input error Fixes issue 1828. ...

13 years, 5 months ago (2011-11-01 04:29:44 UTC) #3

rog

13 years, 5 months ago (2011-11-02 21:28:30 UTC) #4

http://codereview.appspot.com/5305084/diff/10001/src/pkg/rpc/server.go
File src/pkg/rpc/server.go (right):

http://codereview.appspot.com/5305084/diff/10001/src/pkg/rpc/server.go#newcod...
src/pkg/rpc/server.go:421: service, mtype, req, argv, replyv, keepReading, err
:= server.readRequest(codec)
does that set a record for most number of returned values?

Expand All Messages | Collapse All Messages