Issue 5305068: code review 5305068: crypto/openpgp/error: use Error in names of error impl types

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5305068: code review 5305068: crypto/openpgp/error: use Error in names of error impl types (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by rsc

Modified:
13 years, 5 months ago

Reviewers:

CC:
bradfitz, golang-dev

Visibility:
Public.

Description

crypto/openpgp/error: use Error in names of error impl types Will make gofix for error work better. There is no other indication in this file that these are actually error implementations. (They are only used elsewhere.)

Patch Set 1 #

Patch Set 2 : diff -r eb6fbf796acc https://go.googlecode.com/hg #

Patch Set 3 : diff -r eb6fbf796acc https://go.googlecode.com/hg #

Total comments: 1

Patch Set 4 : diff -r a961b329ce1a https://go.googlecode.com/hg #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	src/pkg/crypto/openpgp/error/error.go	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello bradfitz (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

13 years, 5 months ago (2011-10-28 01:41:26 UTC) #1

bradfitz

LGTM http://codereview.appspot.com/5305068/diff/3001/src/pkg/crypto/openpgp/error/error.go File src/pkg/crypto/openpgp/error/error.go (right): http://codereview.appspot.com/5305068/diff/3001/src/pkg/crypto/openpgp/error/error.go#newcode58 src/pkg/crypto/openpgp/error/error.go:58: var UnknownIssuerError = unknownIssuerError(0) should probably be "var ...

13 years, 5 months ago (2011-10-28 01:45:35 UTC) #2

rsc

On Thu, Oct 27, 2011 at 18:45, <bradfitz@golang.org> wrote: > should probably be "var ErrUnknownIssuer", ...

13 years, 5 months ago (2011-10-28 02:37:28 UTC) #3

rsc

13 years, 5 months ago (2011-10-28 02:38:40 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=e73aab37d5b4 ***

crypto/openpgp/error: use Error in names of error impl types

Will make gofix for error work better.
There is no other indication in this file that
these are actually error implementations.

(They are only used elsewhere.)

R=bradfitz
CC=golang-dev
http://codereview.appspot.com/5305068

Expand All Messages | Collapse All Messages