Issue 5305067: code review 5305067: go/doc: remove os.NewError anti-heuristic

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5305067: code review 5305067: go/doc: remove os.NewError anti-heuristic (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by rsc

Modified:
13 years, 5 months ago

Reviewers:

CC:
golang-dev, adg

Visibility:
Public.

Description

go/doc: remove os.NewError anti-heuristic It will be obsolete when error happens. Submitting this now will make the error transition earlier, at the cost of making a locally-built godoc viewing /pkg/syscall or /pkg/os have some functions appear under the Error type as constructors.

Patch Set 1 #

Patch Set 2 : diff -r eb6fbf796acc https://go.googlecode.com/hg #

Patch Set 3 : diff -r eb6fbf796acc https://go.googlecode.com/hg #

Patch Set 4 : diff -r eb6fbf796acc https://go.googlecode.com/hg #

Patch Set 5 : diff -r 5bacac6befcb https://go.googlecode.com/hg #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -15 lines)			Patch
	M	src/pkg/go/doc/doc.go	View	1	2 chunks	+0 lines, -15 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg

13 years, 5 months ago (2011-10-28 01:41:35 UTC) #1

rsc

13 years, 5 months ago (2011-10-28 02:39:29 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=8d586cdcdb20 ***

go/doc: remove os.NewError anti-heuristic

It will be obsolete when error happens.

Submitting this now will make the error transition earlier,
at the cost of making a locally-built godoc viewing
/pkg/syscall or /pkg/os have some functions appear
under the Error type as constructors.

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/5305067

Expand All Messages | Collapse All Messages