Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1686)

Issue 5303082: code review 5303082: encoding/binary: fix type in test (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by rsc
Modified:
13 years, 5 months ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

encoding/binary: fix type in test Was working only accidentally.

Patch Set 1 #

Patch Set 2 : diff -r eb6fbf796acc https://go.googlecode.com/hg #

Patch Set 3 : diff -r eb6fbf796acc https://go.googlecode.com/hg #

Patch Set 4 : diff -r e73aab37d5b4 https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/encoding/binary/binary_test.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg
13 years, 5 months ago (2011-10-28 01:41:11 UTC) #1
bradfitz
LGTM nice :) On Thu, Oct 27, 2011 at 6:41 PM, <rsc@golang.org> wrote: > Reviewers: ...
13 years, 5 months ago (2011-10-28 01:43:27 UTC) #2
rsc
13 years, 5 months ago (2011-10-28 02:39:01 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=5bacac6befcb ***

encoding/binary: fix type in test

Was working only accidentally.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5303082
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b