Issue 53030043: code review 53030043: go.net/ipv4: handle total length field correctly on Fre...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 53030043: code review 53030043: go.net/ipv4: handle total length field correctly on Fre... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by mikio

Modified:
11 years, 1 month ago

Reviewers:
iant

CC:
golang-codereviews, gobot, dave_cheney.net, iant

Visibility:
Public.

Description

go.net/ipv4: handle total length field correctly on FreeBSD 10 FreeBSD 10 kernel has changed its incoming IPv4 packet handling to stop trimming some IPv4 header fields on raw socket IO. This CL just adapts package's IPv4 header representation to look the same even on FreeBSD 10 kernel. For further information: http://svnweb.freebsd.org/base/head/?view=log&pathrev=226105 http://svnweb.freebsd.org/base/head/?view=log&pathrev=241913 http://svnweb.freebsd.org/base/head/?view=log&pathrev=241923

Patch Set 1 : diff -r 5d2d1fb8de5a https://code.google.com/p/go.net #

Patch Set 2 : diff -r 5d2d1fb8de5a https://code.google.com/p/go.net #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -19 lines)			Patch
M	ipv4/header.go	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	ipv4/header_test.go	View	5 chunks	+26 lines, -18 lines	0 comments	Download
A	ipv4/sys_freebsd.go	View	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

mikio

Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

11 years, 2 months ago (2014-01-16 08:17:59 UTC) #1

mikio

11 years, 1 month ago (2014-01-29 01:23:57 UTC) #6

*** Submitted as
https://code.google.com/p/go/source/detail?r=93f5aef8cb25&repo=net ***

go.net/ipv4: handle total length field correctly on FreeBSD 10

FreeBSD 10 kernel has changed its incoming IPv4 packet handling
to stop trimming some IPv4 header fields on raw socket IO. This CL
just adapts package's IPv4 header representation to look the same
even on FreeBSD 10 kernel.

For further information:
http://svnweb.freebsd.org/base/head/?view=log&pathrev=226105
http://svnweb.freebsd.org/base/head/?view=log&pathrev=241913
http://svnweb.freebsd.org/base/head/?view=log&pathrev=241923

LGTM=iant
R=golang-codereviews, gobot, dave, iant
CC=golang-codereviews
https://codereview.appspot.com/53030043

Expand All Messages | Collapse All Messages