Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1110)

Issue 5299046: code review 5299046: fmt: clean up after reflect.Interface change. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by r
Modified:
12 years, 7 months ago
Reviewers:
rsc
CC:
golang-dev, iant
Visibility:
Public.

Description

fmt: clean up after reflect.Interface change. Store the reflect.Value in the internal print state. Code is simpler, cleaner, and a little faster - back to what it was before the change.

Patch Set 1 #

Patch Set 2 : diff -r db65e054598e https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -60 lines) Patch
M src/pkg/fmt/print.go View 1 23 chunks +68 lines, -60 lines 0 comments Download

Messages

Total messages: 4
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 7 months ago (2011-10-18 22:41:58 UTC) #1
iant
LGTM
12 years, 7 months ago (2011-10-18 23:18:11 UTC) #2
r
*** Submitted as http://code.google.com/p/go/source/detail?r=64907024b8e4 *** fmt: clean up after reflect.Interface change. Store the reflect.Value in ...
12 years, 7 months ago (2011-10-18 23:23:09 UTC) #3
rsc
12 years, 7 months ago (2011-10-19 04:21:08 UTC) #4
LGTM

Could move field in too.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b