Issue 5298087: code review 5298087: math: improved accuracy for Tan

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5298087: code review 5298087: math: improved accuracy for Tan (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by Charlie Dorian

Modified:
13 years, 4 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

math: improved accuracy for Tan

Patch Set 1 #

Patch Set 2 : diff -r b3385d4cb197 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b3385d4cb197 https://go.googlecode.com/hg/ #

Total comments: 1

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+104 lines, -49 lines)			Patch
	M	src/pkg/math/all_test.go	View	1	3 chunks	+1 line, -12 lines	1 comment	Download
	M	src/pkg/math/tan.go	View	1	1 chunk	+103 lines, -37 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Charlie Dorian

Hello rsc@golang.org, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 4 months ago (2011-11-02 17:27:44 UTC) #1

rsc

Looks good. Just want to understand the Pi/2 case a little better. http://codereview.appspot.com/5298087/diff/1003/src/pkg/math/all_test.go File src/pkg/math/all_test.go ...

13 years, 4 months ago (2011-11-02 17:40:15 UTC) #2

Charlie Dorian

On 2011/11/02 17:40:15, rsc wrote: > Looks good. Just want to understand the Pi/2 case ...

13 years, 4 months ago (2011-11-02 18:00:20 UTC) #3

rsc

13 years, 4 months ago (2011-11-02 18:01:24 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=c35eeb1599e9 ***

math: improved accuracy for Tan

R=rsc
CC=golang-dev
http://codereview.appspot.com/5298087

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages