Issue 5298073: code review 5298073: os: use error, io.EOF

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5298073: code review 5298073: os: use error, io.EOF (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by rsc

Modified:
13 years, 4 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

os: use error, io.EOF

Patch Set 1 #

Patch Set 2 : diff -r a7ee8dfa634d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 26990717694c https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f751618f828b https://go.googlecode.com/hg/ #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+235 lines, -255 lines)			Patch
M	src/pkg/os/dir_plan9.go	View	1	8 chunks	+10 lines, -9 lines	0 comments	Download
M	src/pkg/os/dir_unix.go	View	1	3 chunks	+3 lines, -2 lines	0 comments	Download
M	src/pkg/os/dir_windows.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/os/env_plan9.go	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/os/env_unix.go	View	1	3 chunks	+6 lines, -5 lines	0 comments	Download
M	src/pkg/os/env_windows.go	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/os/error.go	View	1	1 chunk	+6 lines, -23 lines	0 comments	Download
M	src/pkg/os/error_plan9.go	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/os/error_posix.go	View	1	3 chunks	+44 lines, -44 lines	0 comments	Download
M	src/pkg/os/exec_plan9.go	View	1	8 chunks	+11 lines, -11 lines	0 comments	Download
M	src/pkg/os/exec_posix.go	View	1	3 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/os/exec_unix.go	View	1	5 chunks	+7 lines, -6 lines	0 comments	Download
M	src/pkg/os/exec_windows.go	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/os/file.go	View	1 2 3	13 chunks	+26 lines, -36 lines	0 comments	Download
M	src/pkg/os/file_plan9.go	View	1	13 chunks	+21 lines, -21 lines	0 comments	Download
M	src/pkg/os/file_posix.go	View	1	13 chunks	+20 lines, -20 lines	0 comments	Download
M	src/pkg/os/file_unix.go	View	1	8 chunks	+12 lines, -12 lines	0 comments	Download
M	src/pkg/os/file_windows.go	View	1	10 chunks	+13 lines, -12 lines	0 comments	Download
M	src/pkg/os/getwd.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/os/os_test.go	View	1 2 3	9 chunks	+13 lines, -13 lines	0 comments	Download
M	src/pkg/os/path.go	View	1	5 chunks	+6 lines, -4 lines	0 comments	Download
M	src/pkg/os/path_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/os/proc.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/os/stat_plan9.go	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/os/stat_windows.go	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/os/sys_bsd.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/os/sys_linux.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/os/sys_plan9.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/os/sys_windows.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/os/time.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 4 months ago (2011-10-28 04:04:36 UTC) #1

rsc

13 years, 4 months ago (2011-11-02 01:49:12 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=5693fcd351c4 ***

os: use error, io.EOF

R=r
CC=golang-dev
http://codereview.appspot.com/5298073

Expand All Messages | Collapse All Messages