code review 5294074: src/pkg/[n-z]*: gofix -r error

src/pkg/[n-z]*: gofix -r error -force=error

[rsc, 2011-10-28 04:06:20]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
FAKE_REPOSITORY

[bsiegert, 2011-10-28 10:53:11]

On Fri, Oct 28, 2011 at 06:06,  <rsc@golang.org> wrote:
> I'd like you to review this change to
> FAKE_REPOSITORY

?

--Benny.

[rsc, 2011-10-28 14:40:49]

On Fri, Oct 28, 2011 at 03:53, Benny Siegert <bsiegert@gmail.com> wrote:
> On Fri, Oct 28, 2011 at 06:06,  <rsc@golang.org> wrote:
>> I'd like you to review this change to
>> FAKE_REPOSITORY
>
> ?

It's not the real repository, since you have to run gofix on a
repository with the various Phase 2 CLs already checked in.

Russ

[iant, 2011-10-30 04:21:09]

LGTM.

http://codereview.appspot.com/5294074/diff/1001/src/pkg/utf8/string.go
File src/pkg/utf8/string.go (right):

http://codereview.appspot.com/5294074/diff/1001/src/pkg/utf8/string.go#newcod...
src/pkg/utf8/string.go:196: // We want the panic in At(i) to satisfy os.Error,
because that's what
From here to the end of the file:

s/os.Error/error/
s/error is the type/error_ is the type/
s/String/Error/

Or, drop the error_ type, import "errors", and use "errors.New".  The result
will not satisfy runtime.Error but I don't see why that matters.

[rsc, 2011-11-02 02:05:39]

*** Submitted as http://code.google.com/p/go/source/detail?r=586479483dd6 ***

src/pkg/[n-z]*: gofix -r error -force=error

R=golang-dev, bsiegert, iant
CC=golang-dev
http://codereview.appspot.com/5294074