code review 5294073: crypto/tls: add Error method to alert

crypto/tls: add Error method to alert

alerts get used as both values and errors.
Rather than introduce an alertError wrapper,
this CL just adds an Error method, which will
satisfy the error interface when the time comes.

[rsc, 2011-10-28 01:41:00]

Hello agl, bradfitz (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg

[bradfitz, 2011-10-28 01:57:02]

LGTM

On Thu, Oct 27, 2011 at 6:41 PM, <rsc@golang.org> wrote:

> Reviewers: agl, bradfitz,
>
> Message:
> Hello agl, bradfitz (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg
>
>
> Description:
> crypto/tls: add Error method to alert
>
> alerts get used as both values and errors.
> Rather than introduce an alertError wrapper,
> this CL just adds an Error method, which will
> satisfy the error interface when the time comes.
>
> Please review this at
http://codereview.appspot.com/**5294073/<http://codereview.appspot.com/5294073/>
>
> Affected files:
>  M src/pkg/crypto/tls/alert.go
>
>
> Index: src/pkg/crypto/tls/alert.go
> ==============================**==============================**=======
> --- a/src/pkg/crypto/tls/alert.go
> +++ b/src/pkg/crypto/tls/alert.go
> @@ -71,3 +71,7 @@
>        }
>        return "alert(" + strconv.Itoa(int(e)) + ")"
>  }
> +
> +func (e alert) Error() string {
> +       return e.String()
> +}
>
>
>

[rsc, 2011-10-28 02:42:36]

*** Submitted as http://code.google.com/p/go/source/detail?r=4c0477230b7d ***

crypto/tls: add Error method to alert

alerts get used as both values and errors.
Rather than introduce an alertError wrapper,
this CL just adds an Error method, which will
satisfy the error interface when the time comes.

R=agl, bradfitz
CC=golang-dev
http://codereview.appspot.com/5294073