Issue 5286042: code review 5286042: crypto/x509: add code for dealing with PKIX public keys.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5286042: code review 5286042: crypto/x509: add code for dealing with PKIX public keys. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by agl1

Modified:
13 years, 5 months ago

Reviewers:

CC:
bradfitz, rsc, golang-dev

Visibility:
Public.

Description

crypto/x509: add code for dealing with PKIX public keys. We also have functions for dealing with PKCS#1 private keys. This change adds functions for PKIX /public/ keys. Most of the time one won't be parsing them because they usually come in certificates, but marshaling them happens and I've previously copied the code from x509.go for this.

Patch Set 1 #

Patch Set 2 : diff -r 65ea102b8d02 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 65ea102b8d02 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r af84b15fbae2 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r af84b15fbae2 https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+203 lines, -99 lines)			Patch
M	src/pkg/crypto/x509/Makefile	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	src/pkg/crypto/x509/pkcs1.go	View	1	1 chunk	+122 lines, -0 lines	0 comments	Download
M	src/pkg/crypto/x509/x509.go	View	1 2 3	2 chunks	+45 lines, -99 lines	0 comments	Download
M	src/pkg/crypto/x509/x509_test.go	View	1	2 chunks	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

agl1

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2011-10-14 18:16:22 UTC) #1

agl1

13 years, 5 months ago (2011-10-14 19:11:30 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=b04a8597454c ***

crypto/x509: add code for dealing with PKIX public keys.

We also have functions for dealing with PKCS#1 private keys. This
change adds functions for PKIX /public/ keys. Most of the time one
won't be parsing them because they usually come in certificates, but
marshaling them happens and I've previously copied the code from
x509.go for this.

R=bradfitz, rsc
CC=golang-dev
http://codereview.appspot.com/5286042

Expand All Messages | Collapse All Messages