Issue 5285043: code review 5285043: build: stop on failed deps.bash

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5285043: code review 5285043: build: stop on failed deps.bash (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by rsc

Modified:
13 years, 5 months ago

Reviewers:

CC:
gri, golang-dev

Visibility:
Public.

Description

build: stop on failed deps.bash Apparently some versions of bash do the ||exit implicitly when in set -e mode, but others do not. ???

Patch Set 1 #

Patch Set 2 : code review 5285043: build: stop on failed deps.bash #

Patch Set 3 : diff -r 461aaa349934 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f650efd9ed8d https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/make.bash	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello gri (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2011-10-14 18:35:09 UTC) #1

rsc

13 years, 5 months ago (2011-10-14 19:54:38 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=ab431d0ace8f ***

build: stop on failed deps.bash

Apparently some versions of bash do the ||exit implicitly
when in set -e mode, but others do not.  ???

R=gri
CC=golang-dev
http://codereview.appspot.com/5285043

Expand All Messages | Collapse All Messages