code review 5284046: csv: fix ssue 2366 - overly aggressive TrimLeadingSpace

csv: fix issue 2366 - overly aggressive TrimLeadingSpace

Address the issue coalescing two records together when TrimLeadingSpace
is set to true.

The input

        a,b,
        c,d,e

Would result with a singled a,b,c,d,e record.
With TrailingComma set to true it should give two records.
With TrailingComma set to false it should be an error.

Fixes issue 2366.

[borman, 2011-10-15 17:04:20]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[peterGo, 2011-10-15 19:15:02]

"The special sentence “Fixes issue 159.” associates the change with issue 159 in
the Go issue tracker. When this change is eventually submitted, the issue
tracker will automatically mark the issue as fixed."
Make a change, Contribution Guidelines.
http://golang.org/doc/contribute.html

Therefore, you need to correct your change description to read as follows.

csv: fix overly aggressive TrimLeadingSpace

Address the issue coalescing two records together when TrimLeadingSpace
is set to true.

The input

        a,b,
        c,d,e

Would result with a singled a,b,c,d,e record.
With TrailingComma set to true it should give two records.
With TrailingComma set to false it should be an error.

Fixes issue 2366.

[r, 2011-10-17 18:08:16]

LGTM

[r, 2011-10-17 18:10:44]

*** Submitted as http://code.google.com/p/go/source/detail?r=a2f87f1676db ***

csv: fix issue 2366 - overly aggressive TrimLeadingSpace

Address the issue coalescing two records together when TrimLeadingSpace
is set to true.

The input

        a,b,
        c,d,e

Would result with a singled a,b,c,d,e record.
With TrailingComma set to true it should give two records.
With TrailingComma set to false it should be an error.

Fixes issue 2366.

R=golang-dev, go.peter.90, r
CC=golang-dev
http://codereview.appspot.com/5284046

Committer: Rob Pike <r@golang.org>

[borman, 2012-01-04 01:55:05]

*** Abandoned ***