code review 5275048: gofmt: fix //line handling

gofmt: fix //line handling

Fixes issue 2369.

[rsc, 2011-10-14 18:56:16]

Hello gri (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[gri, 2011-10-14 19:01:39]

LGTM++

I think there is more to it in general, but I guess it works...

Can you please give the testfiles better names? comment.input or
linecomment.input or something like that?

[rsc, 2011-10-14 19:12:52]

I named the test files test1, test2, etc. so that more tests
can be added without having to keep making entries in
the gofmt_test.go file.  I can rename them, or I can add
a comment to the top of each just saying what it's testing.
Which do you prefer?

[gri, 2011-10-14 19:20:22]

Please rename (for instance comments.input). There will be more tests
for comments, and then it's clear into which files they should go.
Also, both tests could go into one .input file, no?
- gri

On Fri, Oct 14, 2011 at 12:12 PM, Russ Cox <rsc@golang.org> wrote:
> I named the test files test1, test2, etc. so that more tests
> can be added without having to keep making entries in
> the gofmt_test.go file.  I can rename them, or I can add
> a comment to the top of each just saying what it's testing.
> Which do you prefer?
>
>

[rsc, 2011-10-14 19:24:28]

will do; i put them in separate files because when i first
isolated the bug i thought it had to do with comments at EOF

[rsc, 2011-10-14 19:54:46]

*** Submitted as http://code.google.com/p/go/source/detail?r=b9a8bd8ae691 ***

gofmt: fix //line handling

Fixes issue 2369.

R=gri
CC=golang-dev
http://codereview.appspot.com/5275048