Issue 5270046: code review 5270046: http: avoid panic caused by nil URL

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5270046: code review 5270046: http: avoid panic caused by nil URL (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by ality

Modified:
13 years, 5 months ago

Reviewers:

CC:
bradfitz, golang-dev

Visibility:
Public.

Description

http: avoid panic caused by nil URL The current code will panic if an invalid request (one with a nil URL) is passed to the doFollowingRedirects function. Also, remove a redundant nil Header check.

Patch Set 1 #

Patch Set 2 : diff -r 6e34838772f1 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 6e34838772f1 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 6e34838772f1 https://code.google.com/p/go/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	src/pkg/http/client.go	View	1 2 3	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

ality

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

13 years, 5 months ago (2011-10-14 23:35:51 UTC) #1

ality

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 5 months ago (2011-10-14 23:51:24 UTC) #2

bradfitz

13 years, 5 months ago (2011-10-15 00:09:18 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=5b1ad5da9383 ***

http: avoid panic caused by nil URL

The current code will panic if an invalid
request (one with a nil URL) is passed to
the doFollowingRedirects function.

Also, remove a redundant nil Header check.

R=bradfitz
CC=golang-dev
http://codereview.appspot.com/5270046

Committer: Brad Fitzpatrick <bradfitz@golang.org>

Expand All Messages | Collapse All Messages