Issue 5267048: code review 5267048: go spec: clarifying variable declaractions w/ constants

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5267048: code review 5267048: go spec: clarifying variable declaractions w/ constants (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by gri

Modified:
13 years, 5 months ago

Reviewers:
r

CC:
rsc, golang-dev

Visibility:
Public.

Description

go spec: clarifying variable declaractions w/ constants Fixes issue 2377.

Patch Set 2 : diff -r 315ea51607df https://go.googlecode.com/hg/ #

Total comments: 1

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	doc/go_spec.html	View	1	2 chunks	+6 lines, -4 lines	1 comment	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gri

Hello r, rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2011-10-17 19:52:13 UTC) #1

gri

*** Submitted as http://code.google.com/p/go/source/detail?r=b75bf4043016 *** go spec: clarifying variable declaractions w/ constants Fixes issue 2377. ...

13 years, 5 months ago (2011-10-17 19:54:20 UTC) #3

LGTM but... http://codereview.appspot.com/5267048/diff/4001/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/5267048/diff/4001/doc/go_spec.html#newcode1797 doc/go_spec.html:1797: var c = 1i // c has ...

13 years, 5 months ago (2011-10-17 20:06:52 UTC) #4

gri

13 years, 5 months ago (2011-10-17 20:11:46 UTC) #5

Will do in the next rounds.
- Robert

On Mon, Oct 17, 2011 at 1:06 PM,  <r@golang.org> wrote:
> LGTM but...
>
>
> http://codereview.appspot.com/5267048/diff/4001/doc/go_spec.html
> File doc/go_spec.html (right):
>
> http://codereview.appspot.com/5267048/diff/4001/doc/go_spec.html#newcode1797
> doc/go_spec.html:1797: var c = 1i      // c has type complex128
> perhaps want other examples, at least one of
>
> var c0 = 0i // c0 has type complex128
> var c1 = 1 + 1i // c1 has type complex128
> var c2 = 1 + 0i // c2 has type complex128
>
> http://codereview.appspot.com/5267048/
>

Expand All Messages | Collapse All Messages