Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(212)

Issue 5259041: code review 5259041: runtime: faster strings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by dvyukov
Modified:
13 years, 5 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

runtime: faster strings Use FlagNoPointers and do not zeroize memory when allocate strings. test/garbage/parser.out old new run #1 32.923s 32.065s run #2 33.047s 31.931s run #3 32.702s 31.841s run #4 32.718s 31.838s run #5 32.702s 31.868s

Patch Set 1 #

Patch Set 2 : diff -r 9c743824e7d6 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9c743824e7d6 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 2904af657e75 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 2904af657e75 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 8af9a425d907 https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r 8af9a425d907 https://go.googlecode.com/hg/ #

Patch Set 8 : diff -r 8af9a425d907 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -21 lines) Patch
M src/cmd/prof/gopprof View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/runtime/string.goc View 1 2 10 chunks +29 lines, -20 lines 0 comments Download

Messages

Total messages: 3
dvyukov
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 5 months ago (2011-10-12 14:12:39 UTC) #1
rsc
LGTM
13 years, 5 months ago (2011-10-12 14:15:42 UTC) #2
dvyukov
13 years, 5 months ago (2011-10-12 14:40:29 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=92b8c1bf3e95 ***

runtime: faster strings
Use FlagNoPointers and do not zeroize memory when allocate strings.
test/garbage/parser.out        old         new
run #1                     32.923s     32.065s
run #2                     33.047s     31.931s
run #3                     32.702s     31.841s
run #4                     32.718s     31.838s
run #5                     32.702s     31.868s

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5259041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b