code review 5256041: godefs: add enum/const testdata

godefs: add enum/const testdata

Also, add golden output data for linux/arm.

[dave_cheney.net, 2011-10-09 08:43:20]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-10-12 17:38:56]

This sounds like a fine idea but do you know why
Bprintf doesn't work with gcc -O3?  That seems
worth fixing too.

Thanks.
Russ

[dave_cheney.net, 2011-10-12 20:18:40]

I chased it as far as the vararg manipulation in lib9/fmt. This problem showed
up under arm, as garbage in the high word. I think it might be beyond my ability
to fix the problem, but I should be able to build a small test program that
demonstrates the problem.  

Sent from my iPhone

On 13/10/2011, at 4:38, Russ Cox <rsc@golang.org> wrote:

> This sounds like a fine idea but do you know why
> Bprintf doesn't work with gcc -O3?  That seems
> worth fixing too.
> 
> Thanks.
> Russ

[rsc, 2011-10-13 14:42:17]

On Oct 12, 2011 at 16:18, Dave Cheney wrote:
> I chased it as far as the vararg manipulation in lib9/fmt. 
> This problem showed up under arm, as garbage in the
> high word. I think it might be beyond my ability to fix 
> the problem, but I should be able to build a small test
> program that demonstrates the problem.  

Which gcc are you using?  
http://twitter.com/#!/mpmselenic/status/123926408396410880

Russ

[dave_cheney.net, 2011-10-13 21:22:56]

Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[dave_cheney.net, 2011-10-13 21:23:31]

This looks like a clang bug. I've adjusted the comment in tsetdata.c to reflect
that.

PTAL

[rsc, 2011-10-14 21:31:56]

LGTM

[rsc, 2011-10-14 21:34:04]

*** Submitted as http://code.google.com/p/go/source/detail?r=5ebff4e7b666 ***

godefs: add enum/const testdata

Also, add golden output data for linux/arm.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5256041

Committer: Russ Cox <rsc@golang.org>