code review 5254061: gotest: avoid conflicts with the name of the tested package

gotest: avoid conflicts with the name of the tested package

Uses a generic solution of renaming the tested package, instead of
using cryptic names for all other imports, variables and methods
in the generated _testmain.go file.

Fixes issue 2346.

[Esko Luontola, 2011-10-12 22:49:21]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
rsc@golang.org),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-10-14 16:47:38]

sut is an odd name.  how about pkg and pkg_test instead of sut and sut_out?

[r2, 2011-10-14 16:58:17]

On Oct 14, 2011, at 9:47 AM, Russ Cox wrote:

> sut is an odd name.  how about pkg and pkg_test instead of sut and sut_out?

agree. the change looks good - thanks - but 'sut' is peculiar.

-rob

[Esko Luontola, 2011-10-14 18:58:22]

SUT stands for system under test, but I agree that it's not very readable 
name, since it requires knowing an uncommon acronym.

The name "pkg" would describe that it's a package, but not what is the role 
of the package, so it would not be very informative. How about calling them 
"target" and "target_test"?

[Esko Luontola, 2011-10-14 19:20:58]

Hello golang-dev@googlegroups.com, r@google.com (cc:
golang-dev@googlegroups.com, rsc@golang.org),

Please take another look.

[adg, 2011-10-17 03:07:08]

LGTM

[adg, 2011-10-17 03:19:08]

*** Submitted as http://code.google.com/p/go/source/detail?r=0445521cd154 ***

gotest: avoid conflicts with the name of the tested package

Uses a generic solution of renaming the tested package, instead of
using cryptic names for all other imports, variables and methods
in the generated _testmain.go file.

Fixes issue 2346.

R=golang-dev, r, adg
CC=golang-dev, rsc
http://codereview.appspot.com/5254061

Committer: Andrew Gerrand <adg@golang.org>