Issue 5254059: code review 5254059: runtime: fix memory leak in parallel garbage collector

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5254059: code review 5254059: runtime: fix memory leak in parallel garbage collector (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by rsc

Modified:
13 years, 5 months ago

Reviewers:

CC:
golang-dev, dvyukov, r

Visibility:
Public.

Description

runtime: fix memory leak in parallel garbage collector The work buffer management used by the garbage collector during parallel collections leaks buffers. This CL tests for and fixes the leak.

Patch Set 2 : diff -r 2904af657e75 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 3 : diff -r 92b8c1bf3e95 https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -1 line)			Patch
A	src/pkg/runtime/gc_test.go	View	1 2	1 chunk	+24 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/mgc0.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/run.bash	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2011-10-12 12:34:26 UTC) #1

dvyukov

Other than that, LGTM http://codereview.appspot.com/5254059/diff/1002/src/pkg/runtime/gc_test.go File src/pkg/runtime/gc_test.go (right): http://codereview.appspot.com/5254059/diff/1002/src/pkg/runtime/gc_test.go#newcode15 src/pkg/runtime/gc_test.go:15: t.Logf("using %d MB", runtime.MemStats.Sys>>20) sys ...

13 years, 5 months ago (2011-10-12 15:07:25 UTC) #2

rsc

13 years, 5 months ago (2011-10-12 17:23:39 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=0d286f8cd50b ***

runtime: fix memory leak in parallel garbage collector

The work buffer management used by the garbage
collector during parallel collections leaks buffers.
This CL tests for and fixes the leak.

R=golang-dev, dvyukov, r
CC=golang-dev
http://codereview.appspot.com/5254059

Expand All Messages | Collapse All Messages