code review 5248060: container/vector: delete

container/vector: delete
Slices are better:
http://code.google.com/p/go-wiki/wiki/SliceTricks

[r, 2011-10-11 23:30:29]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-10-11 23:33:20]

LGTM

Maybe link to http://code.google.com/p/go-wiki/wiki/SliceTricks in the
change description.


On Tue, Oct 11, 2011 at 4:30 PM, <r@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> container/vector: delete
> Slices are better.
>
> Please review this at
http://codereview.appspot.com/**5248060/<http://codereview.appspot.com/5248060/>
>
> Affected files:
>  M src/cmd/goinstall/main.go
>  M src/pkg/Makefile
>  R src/pkg/container/vector/**Makefile
>  R src/pkg/container/vector/defs.**go
>  R src/pkg/container/vector/**intvector.go
>  R src/pkg/container/vector/**intvector_test.go
>  R src/pkg/container/vector/**nogen_test.go
>  R src/pkg/container/vector/**numbers_test.go
>  R src/pkg/container/vector/**stringvector.go
>  R src/pkg/container/vector/**stringvector_test.go
>  R src/pkg/container/vector/**vector.go
>  R src/pkg/container/vector/**vector_test.go
>  M src/pkg/old/template/template_**test.go
>  R test/vectors.go
>
>
>

[dsymonds, 2011-10-11 23:33:35]

LGTM

vale.

[r, 2011-10-11 23:41:51]

*** Submitted as http://code.google.com/p/go/source/detail?r=c62b6404dbb9 ***

container/vector: delete
Slices are better:
http://code.google.com/p/go-wiki/wiki/SliceTricks

R=golang-dev, bradfitz, dsymonds
CC=golang-dev
http://codereview.appspot.com/5248060

[dsymonds, 2011-10-12 00:53:39]

Congratulations! This CL was lucky number 10,000!


changeset:   10000:c62b6404dbb9
user:        Rob Pike <r@golang.org>
date:        Tue Oct 11 16:41:48 2011 -0700
summary:     container/vector: delete

[adg, 2011-10-12 02:32:24]

On 12 October 2011 11:53, David Symonds <dsymonds@golang.org> wrote:
> Congratulations! This CL was lucky number 10,000!
>
>
> changeset:   10000:c62b6404dbb9
> user:        Rob Pike <r@golang.org>
> date:        Tue Oct 11 16:41:48 2011 -0700
> summary:     container/vector: delete
>

And it was one of the first packages:

changeset:   53:0eafa0ebf60e
user:        Rob Pike <r@golang.org>
date:        Thu Apr 03 16:38:21 2008 -0700
summary:     Add a rudimentary vector container to ameliorate the
inability to allocate dynamic arrays.

http://code.google.com/p/go/source/detail?r=0eafa0ebf60e

[bradfitz, 2011-10-12 02:39:42]

Hee...

http://code.google.com/p/go/source/browse/src/lib/container/vector.go?spec=sv...

package vector

export Vector, New;

...


On Tue, Oct 11, 2011 at 7:31 PM, Andrew Gerrand <adg@golang.org> wrote:

> On 12 October 2011 11:53, David Symonds <dsymonds@golang.org> wrote:
> > Congratulations! This CL was lucky number 10,000!
> >
> >
> > changeset:   10000:c62b6404dbb9
> > user:        Rob Pike <r@golang.org>
> > date:        Tue Oct 11 16:41:48 2011 -0700
> > summary:     container/vector: delete
> >
>
> And it was one of the first packages:
>
> changeset:   53:0eafa0ebf60e
> user:        Rob Pike <r@golang.org>
> date:        Thu Apr 03 16:38:21 2008 -0700
> summary:     Add a rudimentary vector container to ameliorate the
> inability to allocate dynamic arrays.
>
> http://code.google.com/p/go/source/detail?r=0eafa0ebf60e
>

[r2, 2011-10-12 02:58:31]

line 127 took a long time to get fixed.