Issue 5246054: code review 5246054: try: delete

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5246054: code review 5246054: try: delete (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by r

Modified:
13 years, 5 months ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

try: delete A fun experiment but not carrying its weight.

Patch Set 1 #

Patch Set 2 : diff -r c793d12e34c9 https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -434 lines)			Patch
M	src/cmd/Makefile	View	1 chunk	+0 lines, -1 line	0 comments	Download
R	src/cmd/gotry/Makefile	View	1 chunk	+0 lines, -18 lines	0 comments	Download
R	src/cmd/gotry/gotry	View	1 chunk	+0 lines, -168 lines	0 comments	Download
M	src/pkg/Makefile	View	2 chunks	+0 lines, -2 lines	0 comments	Download
R	src/pkg/try/Makefile	View	1 chunk	+0 lines, -11 lines	0 comments	Download
R	src/pkg/try/try.go	View	1 chunk	+0 lines, -174 lines	0 comments	Download
R	src/pkg/try/try_test.go	View	1 chunk	+0 lines, -60 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2011-10-11 23:14:07 UTC) #1

bradfitz

LGTM On Tue, Oct 11, 2011 at 4:14 PM, <r@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...

13 years, 5 months ago (2011-10-11 23:15:41 UTC) #2

13 years, 5 months ago (2011-10-11 23:17:25 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=4220268f4323 ***

try: delete
A fun experiment but not carrying its weight.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5246054

Expand All Messages | Collapse All Messages