Issue 5233059: code review 5233059: websocket: tweak hybi ReadHandshake to supports Firefox...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5233059: code review 5233059: websocket: tweak hybi ReadHandshake to supports Firefox... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by rpl

Modified:
13 years, 5 months ago

Reviewers:

CC:
golang-dev, ukai, cw, rsc

Visibility:
Public.

Description

websocket: tweak hybi ReadHandshake to supports Firefox implementation Firefox Websocket implementation send a "Connection: keep-alive, upgrade" header during the handshake (and as descripted on the last hybi draft the "Connection" header must include, but doesn't need to be equal to, "upgrade": '4. A "Connection" header field that includes the token "Upgrade", treated as an ASCII case-insensitive value.' From: http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-17#page-23

Patch Set 1 #

Patch Set 2 : diff -r 9c743824e7d6 https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -1 line)			Patch
	M	src/pkg/websocket/hybi.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/pkg/websocket/hybi_test.go	View	1	1 chunk	+49 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rpl

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, ukai@google.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2011-10-12 11:32:32 UTC) #1

rsc

LGTM Thanks Luca. Please complete a CLA as described at http://golang.org/doc/contribute.html#copyright Russ

13 years, 5 months ago (2011-10-14 16:49:18 UTC) #4

rsc

13 years, 5 months ago (2011-10-14 18:27:45 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=22e7ae0f52e3 ***

websocket: tweak hybi ReadHandshake to supports Firefox implementation

Firefox Websocket implementation send a "Connection: keep-alive, upgrade"
header during the handshake (and as descripted on the last hybi draft
the "Connection" header must include, but doesn't need to be equal to,
"upgrade":

   '4. A "Connection" header field that includes the token "Upgrade",
    treated as an ASCII case-insensitive value.'

From:
http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-17#page-23

R=golang-dev, ukai, cw, rsc
CC=golang-dev
http://codereview.appspot.com/5233059

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages