Issue 5233054: code review 5233054: gofmt: fix a couple of crashes, disallow rewrites for i...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5233054: code review 5233054: gofmt: fix a couple of crashes, disallow rewrites for i... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by gri

Modified:
13 years, 5 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

gofmt: fix a couple of crashes, disallow rewrites for incomplete programs The current implementation of formatting for incomplete programs cannot tolerate program rewrites; ignore -rewrite in that case with a warning message (temporary solution). Fix a couple of crashes that were introduced recently. Fixes issue 2348.

Patch Set 1 #

Patch Set 2 : diff -r b4311778f494 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b4311778f494 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f183ae52d934 https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -6 lines)			Patch
	M	src/cmd/gofmt/gofmt.go	View	1	4 chunks	+14 lines, -5 lines	0 comments	Download
	M	src/cmd/gofmt/rewrite.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2011-10-11 01:07:19 UTC) #1

gri

13 years, 5 months ago (2011-10-12 04:49:58 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=2bfba477d53d ***

gofmt: fix a couple of crashes, disallow rewrites for incomplete programs

The current implementation of formatting for incomplete programs
cannot tolerate program rewrites; ignore -rewrite in that case
with a warning message (temporary solution).

Fix a couple of crashes that were introduced recently.

Fixes issue 2348.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5233054

Expand All Messages | Collapse All Messages